From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9019DC43461 for ; Sat, 5 Sep 2020 20:47:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EF142074B for ; Sat, 5 Sep 2020 20:47:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NLVvf4YB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728813AbgIEUrG (ORCPT ); Sat, 5 Sep 2020 16:47:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728663AbgIEUmd (ORCPT ); Sat, 5 Sep 2020 16:42:33 -0400 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7B57C061245; Sat, 5 Sep 2020 13:42:31 -0700 (PDT) Received: by mail-lf1-x143.google.com with SMTP id y2so5584174lfy.10; Sat, 05 Sep 2020 13:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ig51UfBjg6HZoCk+VbyJzirSDSJ63Dqj6PUDPcp4CWo=; b=NLVvf4YB7hYGuUb/lgrVgC2Tgi3erZUs1c31bdIuGrdKSdcpfRIEYXZlGx0X8F5QKe zCSel5Q3zS51E0pfGNnlIwO4pWrbz8UUn75jtMhkNBiFJJzPQ/v3qh8EUAsVxWNyRBNF U/MuUsFviB6PZyTvWwdwL+nHROtMxpN4ugnfA2nFkI1ccXSZ0AUpYyr2+N5PBL5yuMN6 939z6+cTYyvTHFUUITkHaKYeYYsOd+5vEJZlo9QAa62xB/aY8tZ4iOtDA603+7IMJ+p9 NUG9w6TAo6ADeNioq9Q/sMM98EfF9R/DvwghumlFaj9my/hwfdkyqwFJb+/rOIhNRWkH I0vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ig51UfBjg6HZoCk+VbyJzirSDSJ63Dqj6PUDPcp4CWo=; b=jJqEBVuAm7y3+c67NcJKZlejhPgJCU/ut9E/w+K3sDg4WRWdA3EtnuU9GvZ8ORtgo2 Npuyu+5n0J3Dhp7OPuEw1J3UIgaCKdO9QLD4mttNNcCZcKgHNBI2Z+FSs/bqFaVOkNr/ N3X43Rr1ZLRqDaaaDX3tiWVpQQcAx+D/jM39Dr7NrfVyiuaoQaG+75m1ZI9ueebNNOmv UfghEfBqMaAbHCfakoJpVq0hyTr50lP2VEeMTvNVknD9DqbUJXMreaqTkD2u/zu4O8jY o/kY+6JaHLfl8fK13Ovcq1NtKMYucy+UJsaVfQD1IBsofsWYpkDpuCit25l0ooR38mis QjpQ== X-Gm-Message-State: AOAM530JO4nvcCRSeI8mgsOkkzHBGEzHIrEVnftiUM1V4wwhHGuDFaFL yZp9BLnCeTN1QhP+qJazpv8= X-Google-Smtp-Source: ABdhPJy5LvUKtMwAXEcCZ8EaDHnEv15smIiA62myYX5zTqHz3fJxLHq8MhWRFzXZ2LV5P9ZSoTGEQg== X-Received: by 2002:a19:418e:: with SMTP id o136mr6606685lfa.145.1599338550415; Sat, 05 Sep 2020 13:42:30 -0700 (PDT) Received: from localhost.localdomain (109-252-170-211.dynamic.spd-mgts.ru. [109.252.170.211]) by smtp.gmail.com with ESMTPSA id e17sm1677763ljn.18.2020.09.05.13.42.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Sep 2020 13:42:30 -0700 (PDT) From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Laxman Dewangan , Wolfram Sang , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , Andy Shevchenko Cc: linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 06/31] i2c: tegra: Remove error message used for devm_request_irq() failure Date: Sat, 5 Sep 2020 23:41:26 +0300 Message-Id: <20200905204151.25343-7-digetx@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200905204151.25343-1-digetx@gmail.com> References: <20200905204151.25343-1-digetx@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The error message prints number of vIRQ, which isn't a useful information. In practice devm_request_irq() never fails, hence let's remove the bogus message in order to make code cleaner. Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index 9f0269bffab4..2f74bdd75e1c 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -1803,10 +1803,8 @@ static int tegra_i2c_probe(struct platform_device *pdev) ret = devm_request_irq(&pdev->dev, i2c_dev->irq, tegra_i2c_isr, IRQF_NO_SUSPEND, dev_name(&pdev->dev), i2c_dev); - if (ret) { - dev_err(&pdev->dev, "Failed to request irq %i\n", i2c_dev->irq); + if (ret) goto release_dma; - } i2c_set_adapdata(&i2c_dev->adapter, i2c_dev); i2c_dev->adapter.owner = THIS_MODULE; -- 2.27.0