From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Kees Cook <keescook@chromium.org>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
Denis Efremov <efremov@linux.com>,
Julia Lawall <julia.lawall@inria.fr>,
Alex Dewar <alex.dewar90@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] sysfs: Add sysfs_emit and sysfs_emit_at to format sysfs output
Date: Mon, 7 Sep 2020 07:48:29 +0200 [thread overview]
Message-ID: <20200907054829.GB280798@kroah.com> (raw)
In-Reply-To: <743a648dc817cddd2e7046283c868f1c08742f29.camel@perches.com>
On Sun, Sep 06, 2020 at 10:24:20AM -0700, Joe Perches wrote:
> On Sat, 2020-08-29 at 16:48 -0700, Joe Perches wrote:
> > Output defects can exist in sysfs content using sprintf and snprintf.
> >
> > sprintf does not know the PAGE_SIZE maximum of the temporary buffer
> > used for outputting sysfs content and it's possible to overrun the
> > PAGE_SIZE buffer length.
> >
> > Add a generic sysfs_emit function that knows that the size of the
> > temporary buffer and ensures that no overrun is done.
> >
> > Add a generic sysfs_emit_at function that can be used in multiple
> > call situations that also ensures that no overrun is done.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> >
> > V2: Simplify sysfs_emit and add sysfs_emit_at
> > Include Documentation change
>
> Greg? Rafael? Thoughts on this?
I like the idea, give me a chance to catch up on patches, it's still in
my to-review queue...
thanks,
greg k-h
prev parent reply other threads:[~2020-09-07 5:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 23:48 [PATCH V2] sysfs: Add sysfs_emit and sysfs_emit_at to format sysfs output Joe Perches
2020-08-30 0:43 ` Joe Perches
2020-08-30 8:59 ` Julia Lawall
2020-08-30 15:25 ` Denis Efremov
2020-08-30 16:05 ` Joe Perches
2020-09-07 13:36 ` Greg Kroah-Hartman
2020-09-06 17:24 ` Joe Perches
2020-09-07 5:48 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907054829.GB280798@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alex.dewar90@gmail.com \
--cc=corbet@lwn.net \
--cc=efremov@linux.com \
--cc=gustavoars@kernel.org \
--cc=joe@perches.com \
--cc=julia.lawall@inria.fr \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).