From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 4/4] device property: Move fwnode_connection_find_match() under drivers/base/property.c
Date: Mon, 7 Sep 2020 11:04:14 +0200 [thread overview]
Message-ID: <20200907090414.GE1101646@kroah.com> (raw)
In-Reply-To: <20200904125123.83725-5-heikki.krogerus@linux.intel.com>
On Fri, Sep 04, 2020 at 03:51:23PM +0300, Heikki Krogerus wrote:
> The function is now only a helper that searches the
> connection from device graph and then by checking if the
> supplied connection identifier matches a property that
> contains reference.
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> .../driver-api/device_connection.rst | 43 --------
> drivers/base/Makefile | 2 +-
> drivers/base/devcon.c | 101 ------------------
> drivers/base/property.c | 73 +++++++++++++
> include/linux/device.h | 9 --
> include/linux/property.h | 14 +++
> 6 files changed, 88 insertions(+), 154 deletions(-)
> delete mode 100644 Documentation/driver-api/device_connection.rst
You also removed the documentation in this patch, which would have been
fine if you had mentioned it in the changelog text :(
I'll go queue up the first 3 patches of this series, can you split this
up into two?
thanks,
greg k-h
next prev parent reply other threads:[~2020-09-07 9:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 12:51 [PATCH 0/4] Remove struct device_connection Heikki Krogerus
2020-09-04 12:51 ` [PATCH 1/4] device connection: Remove device_connection_find() Heikki Krogerus
2020-09-04 12:51 ` [PATCH 2/4] device connection: Remove device_connection_add() Heikki Krogerus
2020-09-04 12:51 ` [PATCH 3/4] device connection: Remove struct device_connection Heikki Krogerus
2020-09-04 12:51 ` [PATCH 4/4] device property: Move fwnode_connection_find_match() under drivers/base/property.c Heikki Krogerus
2020-09-07 9:04 ` Greg Kroah-Hartman [this message]
2020-09-07 9:13 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907090414.GE1101646@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).