From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70066C43461 for ; Mon, 7 Sep 2020 09:11:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B6A22078E for ; Mon, 7 Sep 2020 09:11:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728206AbgIGJLr (ORCPT ); Mon, 7 Sep 2020 05:11:47 -0400 Received: from inva021.nxp.com ([92.121.34.21]:47850 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727953AbgIGJLm (ORCPT ); Mon, 7 Sep 2020 05:11:42 -0400 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id B34AE200E39; Mon, 7 Sep 2020 11:11:40 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id A6488200D95; Mon, 7 Sep 2020 11:11:40 +0200 (CEST) Received: from localhost (fsr-ub1664-175.ea.freescale.net [10.171.82.40]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id 907C72036B; Mon, 7 Sep 2020 11:11:40 +0200 (CEST) Date: Mon, 7 Sep 2020 12:11:40 +0300 From: Abel Vesa To: Stephen Boyd Cc: Mike Turquette , Stephen Boyd , Rob Herring , Shawn Guo , Sascha Hauer , Fabio Estevam , Philipp Zabel , Anson Huang , Jacky Bai , Peng Fan , Dong Aisheng , Fugang Duan , devicetree , NXP Linux Team , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Linux Kernel Mailing List , linux-clk Subject: Re: [PATCH v2 16/17] arm64: dts: imx8mp: Add media_blk_ctrl node Message-ID: <20200907091140.xh5vnag342odvmao@fsr-ub1664-175> References: <1597406966-13740-1-git-send-email-abel.vesa@nxp.com> <1597406966-13740-17-git-send-email-abel.vesa@nxp.com> <20200819203734.zbndyvf534xey5xy@fsr-ub1664-175> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180622 X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20-08-20 09:31:27, Dong Aisheng wrote: > Hi Rob, Stephen, > > On Thu, Aug 20, 2020 at 4:37 AM Abel Vesa wrote: > > > > On 20-08-18 19:34:14, Dong Aisheng wrote: > > > On Fri, Aug 14, 2020 at 8:12 PM Abel Vesa wrote: > > > > > > > > Some of the features of the media_ctrl will be used by some > > > > different drivers in a way those drivers will know best, so adding the > > > > syscon compatible we allow those to do just that. Only the resets > > > > and the clocks are registered bit the clk-blk-ctrl driver. > > > > > > > > Signed-off-by: Abel Vesa > > > > --- > > > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++ > > > > 1 file changed, 16 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > > index dede0ae..2d6d213 100644 > > > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > > > @@ -736,6 +736,22 @@ > > > > }; > > > > }; > > > > > > > > + aips4: bus@32c00000 { > > > > + compatible = "simple-bus"; > > > > + reg = <0x32c00000 0x400000>; > > > > + #address-cells = <1>; > > > > + #size-cells = <1>; > > > > + ranges; > > > > + > > > > + media_blk_ctrl: clock-controller@32ec0000 { > > > > > > For this combo device, maybe we can directly name it as blk-ctrl@32ec0000. > > > Rob, do you think if we can do that? > > > > > > > I think it was Stephen who suggested we change it to clock-controller in the > > last's version thread. > > > > TBH, I agree with you here, since it makes more sense to be called blk-ctrl > > provided that this is not really just a clock controller. > > > > How do you think? > Stephen, can you give us an argument for leaving it as clock-controller ? > Regards > Aisheng > > > > > + compatible = "fsl,imx8mp-media-blk-ctrl", "syscon"; > > > > + reg = <0x32ec0000 0x10000>; > > > > + > > > > > > Remove unnecessary blank line > > > > > > > Will do. > > > > > Otherwise: > > > Reviewed-by: Dong Aisheng > > > > > > Regards > > > Aisheng > > > > > > > + #clock-cells = <1>; > > > > + #reset-cells = <1>; > > > > + }; > > > > + }; > > > > + > > > > aips5: bus@30c00000 { > > > > compatible = "fsl,aips-bus", "simple-bus"; > > > > reg = <0x30c00000 0x400000>; > > > > -- > > > > 2.7.4 > > > >