From: Andrew Lunn <andrew@lunn.ch>
To: "Pali Rohár" <pali@kernel.org>
Cc: Jason Cooper <jason@lakedaemon.net>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Tomasz Maciej Nowak <tmn505@gmail.com>,
Andre Heider <a.heider@gmail.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases
Date: Mon, 7 Sep 2020 16:42:28 +0200 [thread overview]
Message-ID: <20200907144228.GV3112546@lunn.ch> (raw)
In-Reply-To: <20200907112718.5994-1-pali@kernel.org>
On Mon, Sep 07, 2020 at 01:27:17PM +0200, Pali Rohár wrote:
> Espressobin boards have 3 ethernet ports and some of them got assigned more
> then one MAC address. MAC addresses are stored in U-Boot environment.
>
> Since commit a2c7023f7075c ("net: dsa: read mac address from DT for slave
> device") kernel can use MAC addresses from DT for particular DSA port.
>
> Currently Espressobin DTS file contains alias just for ethernet0.
>
> This patch defines additional ethernet aliases in Espressobin DTS files, so
> bootloader can fill correct MAC address for DSA switch ports if more MAC
> addresses were specified.
>
> DT alias ethernet1 is used for wan port, DT aliases ethernet2 and ethernet3
> are used for lan ports for both Espressobin revisions (V5 and V7).
>
> Fixes: 5253cb8c00a6f ("arm64: dts: marvell: espressobin: add ethernet alias")
> Signed-off-by: Pali Rohár <pali@kernel.org>
I'm not sure a Fixes: is appropriate here. What is actually broken?
This just seems like a new feature.
Andrew
next prev parent reply other threads:[~2020-09-07 15:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 11:27 [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases Pali Rohár
2020-09-07 14:42 ` Andrew Lunn [this message]
2020-09-07 14:52 ` Pali Rohár
2020-09-07 15:43 ` Andrew Lunn
2020-09-07 16:13 ` Pali Rohár
2020-09-07 17:23 ` Andrew Lunn
2020-09-08 7:47 ` Pali Rohár
2020-09-23 16:19 ` Pali Rohár
2020-09-24 8:15 ` Gregory CLEMENT
2020-09-07 17:13 ` Andre Heider
2020-09-07 17:23 ` Andrew Lunn
2020-09-07 17:35 ` Pali Rohár
2020-09-07 17:43 ` Andre Heider
2020-09-07 17:47 ` Pali Rohár
2020-09-07 17:50 ` Andre Heider
2020-09-07 18:50 ` Andrew Lunn
2020-09-07 17:42 ` Pali Rohár
2020-09-07 17:44 ` Andre Heider
2020-09-23 15:01 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907144228.GV3112546@lunn.ch \
--to=andrew@lunn.ch \
--cc=a.heider@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tmn505@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).