From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC890C433E2 for ; Mon, 7 Sep 2020 18:16:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A66FB207DE for ; Mon, 7 Sep 2020 18:16:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599502563; bh=HMfH03YFktrnGLz7Ry3s392p+fH+S8X4kWzPrjgbpkg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=G/rlLYIz+tOysKNxqBpA78yitwc2/MF8/jzVv8eLQg9vcPmbfQ53tZqDii+k/o+dQ hc0RnuBLIymnDwCtJzFKkLJj01jbLAB3nMemL/yIM3lNqNoDKo9oPhuT9vKrF0plt5 KQUpM7zLfIB4tiIGHsBBpEE1Tw5wp6kgpgQPel9Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729454AbgIGSP7 (ORCPT ); Mon, 7 Sep 2020 14:15:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:35472 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728421AbgIGSPy (ORCPT ); Mon, 7 Sep 2020 14:15:54 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2C21020732; Mon, 7 Sep 2020 18:15:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599502553; bh=HMfH03YFktrnGLz7Ry3s392p+fH+S8X4kWzPrjgbpkg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GN5qZaqazHD+wnnLvGnY7Ql7WNXe00bPkZfEj04TvlxU74gIxyU8QfuLcT7DKuPb0 FlHntndMazrilYZA8KUGV7d4kkArPspIbgMNJle3rBSelJVBUsHqSalYlL9j3C1tGN PrX4gFYZlOayburJhKjSmt4f2COWcO+/zPXAIqTE= Date: Mon, 7 Sep 2020 14:15:52 -0400 From: Sasha Levin To: Kristian Evensen Cc: linux-kernel@vger.kernel.org, stable , Daniele Palmas , =?iso-8859-1?Q?Bj=F8rn?= Mork , Jakub Kicinski , Network Development , linux-usb@vger.kernel.org Subject: Re: [PATCH AUTOSEL 4.14 17/33] net: usb: qmi_wwan: add Telit 0x1050 composition Message-ID: <20200907181552.GN8670@sasha-vm> References: <20191026132110.4026-1-sashal@kernel.org> <20191026132110.4026-17-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 07, 2020 at 11:36:37AM +0200, Kristian Evensen wrote: >Hi, > >On Sat, Oct 26, 2019 at 3:27 PM Sasha Levin wrote: >> >> From: Daniele Palmas >> >> [ Upstream commit e0ae2c578d3909e60e9448207f5d83f785f1129f ] >> >> This patch adds support for Telit FN980 0x1050 composition >> >> 0x1050: tty, adb, rmnet, tty, tty, tty, tty >> >> Signed-off-by: Daniele Palmas >> Acked-by: Bjørn Mork >> Signed-off-by: Jakub Kicinski >> Signed-off-by: Sasha Levin >> --- >> drivers/net/usb/qmi_wwan.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c >> index e406a05e79dcd..57e9166b4bff3 100644 >> --- a/drivers/net/usb/qmi_wwan.c >> +++ b/drivers/net/usb/qmi_wwan.c >> @@ -1252,6 +1252,7 @@ static const struct usb_device_id products[] = { >> {QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */ >> {QMI_FIXED_INTF(0x2357, 0x9000, 4)}, /* TP-LINK MA260 */ >> {QMI_QUIRK_SET_DTR(0x1bc7, 0x1040, 2)}, /* Telit LE922A */ >> + {QMI_QUIRK_SET_DTR(0x1bc7, 0x1050, 2)}, /* Telit FN980 */ >> {QMI_FIXED_INTF(0x1bc7, 0x1100, 3)}, /* Telit ME910 */ >> {QMI_FIXED_INTF(0x1bc7, 0x1101, 3)}, /* Telit ME910 dual modem */ >> {QMI_FIXED_INTF(0x1bc7, 0x1200, 5)}, /* Telit LE920 */ >> -- >> 2.20.1 >> > >When testing the FN980 with kernel 4.14, I noticed that the qmi device >was not there. Checking the git log, I see that this patch was never >applied. The patch applies fine, so I guess it was just missed >somewhere. If it could be added to the next 4.14 release, it would be >much appreciated. Interesting, yes - I'm not sure why it's missing. I'll queue it up. -- Thanks, Sasha