From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F2B6C43461 for ; Wed, 9 Sep 2020 03:17:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F324720EDD for ; Wed, 9 Sep 2020 03:17:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729296AbgIIDRV (ORCPT ); Tue, 8 Sep 2020 23:17:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726694AbgIIDRU (ORCPT ); Tue, 8 Sep 2020 23:17:20 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2F71C061573; Tue, 8 Sep 2020 20:17:17 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3775D11E3E4C3; Tue, 8 Sep 2020 20:00:30 -0700 (PDT) Date: Tue, 08 Sep 2020 20:17:16 -0700 (PDT) Message-Id: <20200908.201716.965139535841943259.davem@davemloft.net> To: christophe.jaillet@wanadoo.fr Cc: jes@trained-monkey.org, kuba@kernel.org, linux-hippi@sunsite.dk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] hippi: switch from 'pci_' to 'dma_' API From: David Miller In-Reply-To: <20200908200839.323530-1-christophe.jaillet@wanadoo.fr> References: <20200908200839.323530-1-christophe.jaillet@wanadoo.fr> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Tue, 08 Sep 2020 20:00:30 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET Date: Tue, 8 Sep 2020 22:08:39 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When memory is allocated in 'rr_init_one()' GFP_KERNEL can be used because > it is a probe function and no spinlock is taken in the between. > > When memory is allocated in 'rr_open()' GFP_KERNEL can be used because > it is a '.ndo_open' function (see struct net_device_ops) and no spinlock is > taken in the between. > '.ndo_open' functions are synchronized using the rtnl_lock() semaphore. ... > Signed-off-by: Christophe JAILLET Applied.