From: Corey Minyard <minyard@acm.org>
To: Markus Boehme <markubo@amazon.com>
Cc: openipmi-developer@lists.sourceforge.net,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Stefan Nuernberger <snu@amazon.com>,
SeongJae Park <sjpark@amazon.com>, Amit Shah <aams@amazon.com>
Subject: Re: [PATCH 1/3] ipmi: Reset response handler when failing to send the command
Date: Mon, 7 Sep 2020 19:03:26 -0500 [thread overview]
Message-ID: <20200908000326.GB15602@minyard.net> (raw)
In-Reply-To: <1599495937-10654-1-git-send-email-markubo@amazon.com>
On Mon, Sep 07, 2020 at 06:25:35PM +0200, Markus Boehme wrote:
> When failing to send a command we don't expect a response. Clear the
> `null_user_handler` like is done in the success path.
This is correct. I guess, from the next two patches, I know how you
found this.
I can incude this, but I will ask some questions in the later patches.
-corey
>
> Signed-off-by: Markus Boehme <markubo@amazon.com>
> ---
> drivers/char/ipmi/ipmi_msghandler.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index 737c0b6..2b213c9 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -2433,7 +2433,7 @@ static int __get_device_id(struct ipmi_smi *intf, struct bmc_device *bmc)
>
> rv = send_get_device_id_cmd(intf);
> if (rv)
> - return rv;
> + goto out_reset_handler;
>
> wait_event(intf->waitq, bmc->dyn_id_set != 2);
>
> @@ -2443,6 +2443,7 @@ static int __get_device_id(struct ipmi_smi *intf, struct bmc_device *bmc)
> /* dyn_id_set makes the id data available. */
> smp_rmb();
>
> +out_reset_handler:
> intf->null_user_handler = NULL;
>
> return rv;
> @@ -3329,6 +3330,7 @@ static int __scan_channels(struct ipmi_smi *intf, struct ipmi_device_id *id)
> dev_warn(intf->si_dev,
> "Error sending channel information for channel 0, %d\n",
> rv);
> + intf->null_user_handler = NULL;
> return -EIO;
> }
>
> --
> 2.7.4
>
prev parent reply other threads:[~2020-09-08 0:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 16:25 [PATCH 1/3] ipmi: Reset response handler when failing to send the command Markus Boehme
2020-09-07 16:25 ` [PATCH 2/3] ipmi: Add timeout waiting for device GUID Markus Boehme
2020-09-08 0:07 ` Corey Minyard
2020-09-07 16:25 ` [PATCH 3/3] ipmi: Add timeout waiting for channel information Markus Boehme
2020-09-08 0:34 ` Corey Minyard
2020-09-10 11:08 ` Boehme, Markus
2020-10-07 18:42 ` [Openipmi-developer] " Corey Minyard
2020-09-08 0:03 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908000326.GB15602@minyard.net \
--to=minyard@acm.org \
--cc=aams@amazon.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markubo@amazon.com \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=sjpark@amazon.com \
--cc=snu@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).