From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B81CBC43461 for ; Tue, 8 Sep 2020 02:16:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C2C321481 for ; Tue, 8 Sep 2020 02:16:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nl2e0IM6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728748AbgIHCQi (ORCPT ); Mon, 7 Sep 2020 22:16:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728250AbgIHCLj (ORCPT ); Mon, 7 Sep 2020 22:11:39 -0400 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 860DFC061575; Mon, 7 Sep 2020 19:11:38 -0700 (PDT) Received: by mail-lf1-x143.google.com with SMTP id y17so8295560lfa.8; Mon, 07 Sep 2020 19:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=q11uImOBu+1Xg7DG63K2wClGRfbxHQUXss5cA3+a/Zc=; b=nl2e0IM6qXYLA2p2QFQ8L0/Ye3fpnq1RUuLtQklUtCoMvzTMW5XWxYgq2nIHZZd0dE pxco2YBKEG7630XZbZaL48J1nvcCfVdKMvCucZAzjQXDFPTPDb1iqyr9wehAzO1z+TlL A0qRCg+ebR7SZ1Va6EmynCHKWaRGlraUjEEP76Yy58T1OXQi/vXz3zWELquPDVlOITOJ 8njWlyxtdwYZ2ujfxiaXoDMIytUo3cdMX/sCTfuycwYeUifxnfjvkKCvX5TMBtB65fP1 7XeSMplgcoj5I5US36J7NAjIMY+a+zSXykhlBPMP+egiwypAXFi3Xadg56vi2mRQSLBq GbyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=q11uImOBu+1Xg7DG63K2wClGRfbxHQUXss5cA3+a/Zc=; b=o4gti+nwxcY4shetKCnwpYABde0l0tvClXGRcqvlrCPPVjVzYKm6/Gr2RlgRJA8inz bl9uNEekL+YU3lvvVWF/hmrDeYg61OB5JiTzwtFfCGvXUJ8px9mL9xT+9ptErWudmCfm DdycTRNC/RgnyK28PaowyF2K2iUWSwMyB9ys+rEo92icIo6WDqlY6QvxWyarZBxCcvRy XiQu43sSJ0CaGv3K91VfEobwRXZp0nIAK0znVTjuMieulV9uWWuu2fn+TungnIqezvQe 0YIDRLxe2Bx1S6aM8tRCHMA9AkNLVilxa0reRgM+ofwu5IrN624WmC71VNRHmd0Gp0qq kx9Q== X-Gm-Message-State: AOAM531UORsgLwZuycHLFnRosuhJGUFKa5jmCOAmDH4Els3CgIjN+EzG BMlZ9c/+2KB6demPHvWFx1c= X-Google-Smtp-Source: ABdhPJxm1DSiS0+1Dc72ob/e65fGJ9NRNcCyz711XfQSn4Wnso0AVFKXhGfH3OjPaYlSzVeK79bIBw== X-Received: by 2002:a05:6512:370e:: with SMTP id z14mr11268631lfr.80.1599531095387; Mon, 07 Sep 2020 19:11:35 -0700 (PDT) Received: from localhost.localdomain (109-252-170-211.dynamic.spd-mgts.ru. [109.252.170.211]) by smtp.gmail.com with ESMTPSA id j12sm9070085lfj.5.2020.09.07.19.11.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Sep 2020 19:11:34 -0700 (PDT) From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Laxman Dewangan , Wolfram Sang , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , Andy Shevchenko Cc: linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 00/35] Improvements for Tegra I2C driver Date: Tue, 8 Sep 2020 05:09:46 +0300 Message-Id: <20200908021021.9123-1-digetx@gmail.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! This series performs refactoring of the Tegra I2C driver code and hardens the atomic-transfer mode. Changelog: v6: - Added new patch that adds missing RPM puts, thanks to Andy Shevchenko for the suggestion. - Improved commit messages by extending them with more a more detailed explanation of the changes. - Added clarifying comment to the "Use reset_control_reset()" change, which was asked by Andy Shevchenko. - Refactored the "Clean up probe function" patch by moving the dev_err_probe() change into the "Use clk-bulk helpers" patch, which was suggested by Andy Shevchenko. - Improved ordering of the patches like it was suggested by Andy Shevchenko. - Added Andy Shevchenko to suggested-by of the "Use clk-bulk helpers" patch. - Improved "Remove i2c_dev.clk_divisor_non_hs_mode member" patch by making the case-switch to use "fast plus mode" timing if clock rate is out-of-range. Just to make it more consistent. - The "Improve tegra_i2c_dev structure" patch is squashed into "Improve formatting of variables" and "Clean up types/names" patches. - All variable-renaming changes are squashed into a single "Clean up variable names" patch. - Made extra minor improvement to various patches, like more comments and indentations improved. v5: - Dropped the "Factor out runtime PM and hardware initialization" patch, like it was suggested by Michał Mirosław. Instead a less invasive "Factor out hardware initialization into separate function" patch added, it doesn't touch the RPM initialization. - The "Remove outdated barrier()" patch now removes outdated comments. - Updated commit description of the "Remove "dma" variable" patch, saying that the transfer mode may be changed by a callee. This was suggested by Michał Mirosław. - Reworked the "Clean up and improve comments" patch. Couple more comments are corrected and reworded now. - Added r-b's from Michał Mirosław. - New patches: i2c: tegra: Mask interrupt in tegra_i2c_issue_bus_clear() i2c: tegra: Remove redundant check in tegra_i2c_issue_bus_clear() i2c: tegra: Don't fall back to PIO mode if DMA configuration fails i2c: tegra: Clean up variable types i2c: tegra: Improve tegra_i2c_dev structure v4: - Reordered patches in the fixes/features/cleanups order like it was suggested by Andy Shevchenko. - Now using clk-bulk API, which was suggested by Andy Shevchenko. - Reworked "Make tegra_i2c_flush_fifos() usable in atomic transfer" patch to use iopoll API, which was suggested by Andy Shevchenko. - Separated "Clean up probe function" into several smaller patches. - Squashed "Add missing newline before returns" patch into "Clean up whitespaces, newlines and indentation". - The "Drop '_timeout' from wait/poll function names" is renamed to "Rename wait/poll functions". - The "Use reset_control_reset()" is changed to not fail tegra_i2c_init(), but only emit warning. This should be more friendly behaviour in oppose to having a non-bootable machine if reset-control fails. - New patches: i2c: tegra: Remove error message used for devm_request_irq() failure i2c: tegra: Use devm_platform_get_and_ioremap_resource() i2c: tegra: Use platform_get_irq() i2c: tegra: Use clk-bulk helpers i2c: tegra: Remove bogus barrier() i2c: tegra: Factor out register polling into separate function i2c: tegra: Consolidate error handling in tegra_i2c_xfer_msg() i2c: tegra: Clean up and improve comments i2c: tegra: Rename couple "ret" variables to "err" v3: - Optimized "Make tegra_i2c_flush_fifos() usable in atomic transfer" patch by pre-checking FIFO state before starting to poll using ktime API, which may be expensive under some circumstances. - The "Clean up messages in the code" patch now makes all messages to use proper capitalization of abbreviations. Thanks to Andy Shevchenko and Michał Mirosław for the suggestion. - The "Remove unnecessary whitespaces and newlines" patch is transformed into "Clean up whitespaces and newlines", it now also adds missing newlines and spaces. - Reworked the "Clean up probe function" patch in accordance to suggestion from Michał Mirosław by factoring out only parts of the code that make error unwinding cleaner. - Added r-b from Michał Mirosław. - Added more patches: i2c: tegra: Reorder location of functions in the code i2c: tegra: Factor out packet header setup from tegra_i2c_xfer_msg() i2c: tegra: Remove "dma" variable i2c: tegra: Initialization div-clk rate unconditionally i2c: tegra: Remove i2c_dev.clk_divisor_non_hs_mode member v2: - Cleaned more messages in the "Clean up messages in the code" patch. - The error code of reset_control_reset() is checked now. - Added these new patches to clean up couple more things: i2c: tegra: Check errors for both positive and negative values i2c: tegra: Improve coding style of tegra_i2c_wait_for_config_load() i2c: tegra: Remove unnecessary whitespaces and newlines i2c: tegra: Rename variable in tegra_i2c_issue_bus_clear() i2c: tegra: Improve driver module description Dmitry Osipenko (35): i2c: tegra: Make tegra_i2c_flush_fifos() usable in atomic transfer i2c: tegra: Add missing runtime PM put i2c: tegra: Handle potential error of tegra_i2c_flush_fifos() i2c: tegra: Mask interrupt in tegra_i2c_issue_bus_clear() i2c: tegra: Initialize div-clk rate unconditionally i2c: tegra: Remove i2c_dev.clk_divisor_non_hs_mode member i2c: tegra: Runtime PM always available on Tegra i2c: tegra: Remove error message used for devm_request_irq() failure i2c: tegra: Use reset_control_reset() i2c: tegra: Use devm_platform_get_and_ioremap_resource() i2c: tegra: Use platform_get_irq() i2c: tegra: Use clk-bulk helpers i2c: tegra: Move out all device-tree parsing into tegra_i2c_parse_dt() i2c: tegra: Clean up probe function i2c: tegra: Clean up variable types i2c: tegra: Reorder location of functions in the code i2c: tegra: Remove likely/unlikely from the code i2c: tegra: Remove outdated barrier() i2c: tegra: Remove redundant check in tegra_i2c_issue_bus_clear() i2c: tegra: Remove "dma" variable from tegra_i2c_xfer_msg() i2c: tegra: Don't fall back to PIO mode if DMA configuration fails i2c: tegra: Improve formatting of variables i2c: tegra: Improve coding style of tegra_i2c_wait_for_config_load() i2c: tegra: Rename wait/poll functions i2c: tegra: Factor out error recovery from tegra_i2c_xfer_msg() i2c: tegra: Factor out packet header setup from tegra_i2c_xfer_msg() i2c: tegra: Factor out register polling into separate function i2c: tegra: Factor out hardware initialization into separate function i2c: tegra: Check errors for both positive and negative values i2c: tegra: Consolidate error handling in tegra_i2c_xfer_msg() i2c: tegra: Clean up variable names i2c: tegra: Clean up printk messages i2c: tegra: Clean up and improve comments i2c: tegra: Clean up whitespaces, newlines and indentation i2c: tegra: Improve driver module description drivers/i2c/busses/i2c-tegra.c | 1428 ++++++++++++++++---------------- 1 file changed, 698 insertions(+), 730 deletions(-) -- 2.27.0