From: Nathan Chancellor <natechancellor@gmail.com>
To: Arvind Sankar <nivedita@alum.mit.edu>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Sedat Dilek <sedat.dilek@gmail.com>,
Marco Elver <elver@google.com>,
Andrey Konovalov <andreyknvl@google.com>,
Masahiro Yamada <masahiroy@kernel.org>,
clang-built-linux@googlegroups.com,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Will Deacon <will@kernel.org>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/7] set clang minimum version to 10.0.1
Date: Mon, 7 Sep 2020 21:42:18 -0700 [thread overview]
Message-ID: <20200908044218.GB1422621@ubuntu-n2-xlarge-x86> (raw)
In-Reply-To: <20200907161230.GA2149325@rani.riverdale.lan>
On Mon, Sep 07, 2020 at 12:12:30PM -0400, Arvind Sankar wrote:
> On Wed, Sep 02, 2020 at 03:59:04PM -0700, Nick Desaulniers wrote:
> > Adds a compile time #error to compiler-clang.h setting the effective
> > minimum supported version to clang 10.0.1. A separate patch has already
> > been picked up into the Documentation/ tree also confirming the version.
> >
>
> Is 10.0.1 actually required or could it just check major version? I have
> 10.0.0 currently and at least x86 seems to be building fine.
>
> Thanks.
There was a decent amount of effort put in to testing LLVM 10.0.1 and
making sure that it could handle the kernel. I know of a few backend
errors that were fixed and backported to 10.0.1:
https://github.com/ClangBuiltLinux/linux/issues/944
https://github.com/ClangBuiltLinux/linux/issues/954
Plus there was this rather nasty ld.lld crash in 10.0.0 that just
x86_64_defconfig triggers with mainline:
https://github.com/ClangBuiltLinux/linux/issues/962
I do not have any strong opinions around checking just major version but
I would prefer that we stick with 10.0.1 because it has been tested
against several kernel configs unlike 10.0.0. However, I know that Kees
mentioned that Ubuntu 20.04 shipped clang 10.0.0 and there is no 10.0.1
available yet. Presumably it is coming down the pipeline from Debian
since 10.0.1 appears to be in testing? I suppose if 10.0.0 is shipped in
multiple places without an easy upgrade path to 10.0.1, we should
consider softening up this version check, at least for the time being. I
just worry about duplicate reports.
Cheers,
Nathan
next prev parent reply other threads:[~2020-09-08 4:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 22:59 [PATCH v3 0/7] set clang minimum version to 10.0.1 Nick Desaulniers
2020-09-02 22:59 ` [PATCH v3 1/7] compiler-clang: add build check for clang 10.0.1 Nick Desaulniers
2020-11-03 4:55 ` Jarkko Sakkinen
2020-11-03 6:38 ` Nathan Chancellor
2020-11-03 9:00 ` Jarkko Sakkinen
2020-11-03 18:48 ` Nick Desaulniers
2020-11-04 0:38 ` Jarkko Sakkinen
2020-11-04 1:18 ` Nick Desaulniers
2020-11-04 1:34 ` Jarkko Sakkinen
2020-11-04 1:36 ` Jarkko Sakkinen
2020-11-17 3:04 ` John Hubbard
2020-11-17 18:46 ` Nick Desaulniers
2020-11-18 2:31 ` Nathan Chancellor
2020-11-18 2:37 ` Andrew Morton
2020-09-02 22:59 ` [PATCH v3 2/7] Revert "kbuild: disable clang's default use of -fmerge-all-constants" Nick Desaulniers
2020-09-02 22:59 ` [PATCH v3 3/7] Revert "arm64: bti: Require clang >= 10.0.1 for in-kernel BTI support" Nick Desaulniers
2020-09-02 22:59 ` [PATCH v3 4/7] Revert "arm64: vdso: Fix compilation with clang older than 8" Nick Desaulniers
2020-09-02 22:59 ` [PATCH v3 5/7] Partially revert "ARM: 8905/1: Emit __gnu_mcount_nc when using Clang 10.0.0 or newer" Nick Desaulniers
2020-09-02 22:59 ` [PATCH v3 6/7] kasan: Remove mentions of unsupported Clang versions Nick Desaulniers
2020-09-02 22:59 ` [PATCH v3 7/7] compiler-gcc: improve version error Nick Desaulniers
2020-09-07 21:25 ` Will Deacon
2020-09-03 14:06 ` [PATCH v3 0/7] set clang minimum version to 10.0.1 Sedat Dilek
2020-09-03 17:28 ` Nathan Chancellor
2020-09-04 5:42 ` Miguel Ojeda
2020-09-07 16:12 ` Arvind Sankar
2020-09-08 4:42 ` Nathan Chancellor [this message]
2020-09-07 21:26 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908044218.GB1422621@ubuntu-n2-xlarge-x86 \
--to=natechancellor@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=ast@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=daniel@iogearbox.net \
--cc=elver@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ndesaulniers@google.com \
--cc=nivedita@alum.mit.edu \
--cc=sedat.dilek@gmail.com \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).