From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB615C43461 for ; Tue, 8 Sep 2020 09:36:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 950CD2177B for ; Tue, 8 Sep 2020 09:36:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zRfCxghf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728957AbgIHJgC (ORCPT ); Tue, 8 Sep 2020 05:36:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727995AbgIHJfx (ORCPT ); Tue, 8 Sep 2020 05:35:53 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25EC1C061573 for ; Tue, 8 Sep 2020 02:35:43 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id a9so16458748wmm.2 for ; Tue, 08 Sep 2020 02:35:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=BeqWiKyy2q9h196I07hlm698YeqsB6n9xDnRMOn41fE=; b=zRfCxghfDE520rmBsbZWLpRUQoNwbS7ZJswAcOp3EFCxZF/qxDkslg0bMkhEaPbnvQ uQoIootj9J20mEuW52nBQncMupNt1Z/lrCEUp/hTHF2cbW4ze5phqMwUHXT88Onf6T6U XPt1SuCD3Pnx/vROIgCZq2UKCI8XwvSjGmQKOioKp15LciAkortrb6a+oqK2wy+7ceiI 6hNREpWE+8PRikBCPMWWciaHI7emd+oSPkxLRmdsOyvZBcQbUOS4zc4yyIT4eFeywSTO 0Inzytl0SCyaQ4Yegfmjydgu/XZk4F5SHVzA2/rJ6rW8YxtvwaYnGVSSvD2+AazINpeM 5Kag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=BeqWiKyy2q9h196I07hlm698YeqsB6n9xDnRMOn41fE=; b=ZzPhQFVuIbrFrHiKBuVU7X+kp1xbvugw3yoaAKhT5dc15KP8mXAJXn4MzEPWw8wZvV w4cc3J5kHvp/NgDXXoxgc16mJyqqDy0EQXU2hIt6ImH1b9KEFUqvRo1Klp2ZZbT6N+E8 rFwiUsZEwyrcs8zoiYAmoAzxjbHSl02N9MylP7PC7SmlynrFrWRya6mQZdMp+5JC68sf ViFfxAwOpIQpmFPt+IoHiHAWijvWkJhDNSDumw+ttXC8Tlu0hmIT8g1nV+mpkCRarjML zRHef30NHihY0g/EvpzDN18oUsI6ucS8oKzeOxH631s7BAVODTNmlhpdLmzXDhY6cV4v 2NYg== X-Gm-Message-State: AOAM533f/oZ8KRYfEr2ftLAxWXpfUegMPfG6ti3Awjo3djQxNAIIAQ67 9e7Wu0cEenbz0/hwPfEZduzMng== X-Google-Smtp-Source: ABdhPJwSGVcSB7tECrf90WTk449mkRJzFsiMZbiOsDL0m1RNcYjJzM6A1ZUkahuSc+wylUXYyogdpQ== X-Received: by 2002:a1c:7d0c:: with SMTP id y12mr3504117wmc.103.1599557742367; Tue, 08 Sep 2020 02:35:42 -0700 (PDT) Received: from dell ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id q12sm32786028wrp.17.2020.09.08.02.35.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 02:35:41 -0700 (PDT) Date: Tue, 8 Sep 2020 10:35:38 +0100 From: Lee Jones To: Andy Shevchenko Cc: Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , "linux-kernel@vger.kernel.org" , Rob Herring , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Alessandro Zummo , Alexandre Belloni , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sam Ravnborg , Linus Walleij , Heiko Stuebner , Stephan Gerhold , Lubomir Rintel , Mark Brown , allen , Mauro Carvalho Chehab , "David S. Miller" , "devicetree@vger.kernel.org" , "linux-pwm@vger.kernel.org" , "linux-rtc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Heiko Stuebner , Josua Mayer , Andreas Kemnade , Arnd Bergmann , Daniel Palmer Subject: Re: [PATCH v2 05/10] pwm: ntxec: Add driver for PWM function in Netronix EC Message-ID: <20200908093538.GM4400@dell> References: <20200905133230.1014581-1-j.neuschaefer@gmx.net> <20200905133230.1014581-6-j.neuschaefer@gmx.net> <20200908081445.GC4400@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 08 Sep 2020, Andy Shevchenko wrote: > On Tue, Sep 8, 2020 at 11:14 AM Lee Jones wrote: > > On Sat, 05 Sep 2020, Andy Shevchenko wrote: > > > On Saturday, September 5, 2020, Jonathan Neuschäfer > > > wrote: > > ... > > > > > +config PWM_NTXEC > > > > + tristate "Netronix embedded controller PWM support" > > > > > > > > > > > > > > > > + depends on MFD_NTXEC && OF > > > > > > > > > I don’t see need to reduce test coverage and use of the driver by sticking > > > with OF. Actually it’s not used. > > > > If the device is only known to boot with OF, then it's pointless > > building it when !OF. > > No, it's not. As I pointed out the (compilation) test coverage is better. No, it's a waste of disk space. Why would you knowingly compile something you know you can't use? That's the whole point of COMPILE_TEST. Note that when you want real coverage and you use `allyesconfig` and/or `allmodconfig` then CONFIG_OF is also enabled on platforms which support it. > > If you want to increase test coverage enable > > COMPILE_TEST instead. > > It is one way to achieve that, yes; > > depends on OF || COMPILE_TEST > depends on MFD_NTXEC This is better. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog