From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C92DC43461 for ; Tue, 8 Sep 2020 11:27:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3190A20936 for ; Tue, 8 Sep 2020 11:27:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Hb/Gwn9Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729789AbgIHL07 (ORCPT ); Tue, 8 Sep 2020 07:26:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729753AbgIHLS0 (ORCPT ); Tue, 8 Sep 2020 07:18:26 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0405DC061755 for ; Tue, 8 Sep 2020 04:18:22 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id s2so7866209pjr.4 for ; Tue, 08 Sep 2020 04:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+yj7E7wqvb/129I+Etr+MWEdaS4FH4xTeleftUlUtU0=; b=Hb/Gwn9Q/dtKSqnvZ8CsNoSc8NYoacrOTGentUWFuYZ//RBTfJZCyLOSWy3EEoxKDI kixhwhlBZq4YpgWNwSiOzuMXgKVLUOLMjGvMRPGjYqGRxnWKHaGVDLaCsE9kqTH6JBd+ CuypC+LI0FACS3fjyRl0huAdpR6fGhldDovl5EgHkRYh7NIgDwklkaOAadhL4w5awKqb fcKc0Kiya8KXN3Cxvi6DMeoXYx8qwSxIZ0PfNEE/pF1dh/himAYdEWSCv7Y3g8rCm5yk 3Kcm+ukMRsqtYIyJ+oujORqhgEAEFP3B/s1Y/ZjiSMZLek8wYEcmOzDzWT2TrLnC8jgU ykuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+yj7E7wqvb/129I+Etr+MWEdaS4FH4xTeleftUlUtU0=; b=mihRnUF2IltSLTVmt1u3vkd9KucmMYCD01CkCE73v1MRvS+mbtnOCfzdsRvx1WSMt8 BamxwmBTYMsDrfiknZaGR0QbGuKwEqu5Ee8kpSOifiryMZ12Q33nicEyWrpHvH9c/BLd P6QjI+jujYJOVwbPnk6IX+m7C2dSK3hUcYpT6AF66BWiLmbiMLAup96tMY5kgFLSwmcl Y7oY5IpqJ78CCqI8ewG0CWsVewa2/ixBsc0AvjJWy8MeI5YvNdZ2QhHvf1bI7i8GoLp1 DKr5D/KsHeQzr+952hda3Y7IFyIEsw99uFgro3dhnfQtHEC2Cf0zPl0VE1MOVBMwhBPG /98Q== X-Gm-Message-State: AOAM531S9eS3CfR/zUwm8Ww/qw/h+XVT2RfaPM1aV0E/9yvNBa1wwJ7s zZ7kyxWMuyx0nvTSjO71Np0mzA== X-Google-Smtp-Source: ABdhPJw9bzz24JCxWhsSf3D3RLPNqdC6upw7cihvDBWKSthLxWatIl456zfxZ+IDAO52Lkc38DGmHQ== X-Received: by 2002:a17:90a:2e0f:: with SMTP id q15mr3551524pjd.49.1599563901563; Tue, 08 Sep 2020 04:18:21 -0700 (PDT) Received: from localhost ([122.181.54.133]) by smtp.gmail.com with ESMTPSA id ie13sm16070458pjb.5.2020.09.08.04.18.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Sep 2020 04:18:20 -0700 (PDT) Date: Tue, 8 Sep 2020 16:48:13 +0530 From: Viresh Kumar To: Manivannan Sadhasivam Cc: rjw@rjwysocki.net, robh+dt@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, amitk@kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dmitry.baryshkov@linaro.org, tdas@codeaurora.org Subject: Re: [PATCH 5/7] cpufreq: qcom-hw: Use regmap for accessing hardware registers Message-ID: <20200908111813.bbgfxo5v7qt6ujpc@vireshk-i7> References: <20200908075716.30357-1-manivannan.sadhasivam@linaro.org> <20200908075716.30357-6-manivannan.sadhasivam@linaro.org> <20200908103444.5e526uawa45om6lt@vireshk-i7> <20200908111141.GB23095@mani> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200908111141.GB23095@mani> User-Agent: NeoMutt/20180716-391-311a52 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08-09-20, 16:41, Manivannan Sadhasivam wrote: > On 0908, Viresh Kumar wrote: > > On 08-09-20, 13:27, Manivannan Sadhasivam wrote: > > > Use regmap for accessing cpufreq registers in hardware. > > > > Why ? Please mention why a change is required in the log. > > > > Only because it is recommended to use regmap for abstracting the hw access. Yes it can be very useful in abstracting the hw access in case of busses like SPI/I2C, others, but in this case there is only one way of doing it with the exact same registers. I am not sure it is worth it here. FWIW, I have never played with regmaps personally, and so every chance I can be wrong here. > Moreover it handles the proper locking for us in the core (spinlock vs mutex). What locking do you need here ? > I've seen many subsystem maintainers prefer regmap over plain readl/writel > calls. I'll add the reason in commit log. I am not sure if it is worth it here. -- viresh