From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AAD4C43461 for ; Tue, 8 Sep 2020 18:07:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D08E2078E for ; Tue, 8 Sep 2020 18:07:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599588470; bh=t7T7Hv6djcVNu/mOs3I8WDKRkVDXHKWlUme4E61ZPk8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=eJOZjHmkL9/nJ9/i5Ee3Fa8t1CKzqMNbB2yVFbcUCghhbc6Dy5Q0bnrI3PJMSAWJm w60YL1N7DZNU1hR5cC0um/OaHBjGwV2kYsHDJUbL0+jDX02dDNDccVhxpxl7pQU6vz qwkE6g7Ot9Ks0Q56JPbZNxI7mxaHKk73u//8NQ2E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732266AbgIHSHr (ORCPT ); Tue, 8 Sep 2020 14:07:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:56078 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731471AbgIHQLu (ORCPT ); Tue, 8 Sep 2020 12:11:50 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4FACB2476E; Tue, 8 Sep 2020 15:41:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599579714; bh=t7T7Hv6djcVNu/mOs3I8WDKRkVDXHKWlUme4E61ZPk8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ny3Aq1fEeVaZyONwaRmASghpy582Q1IoDXOTl7z4rXsSNi/pGueMgFPPMcD5bzMLO W89pHkkwxU8E8AcQJc3+N/xJFklZbIYvDQxbxZ9KLbnsYe2PAe9CyR/B3gY5Z2HCXG FAj59PoL6A4bkM9wXQUBIRnBV5NIeGYaitYiPXrM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Randy Dunlap , "Steven Rostedt (VMware)" , Masahiro Yamada Subject: [PATCH 5.8 178/186] kconfig: streamline_config.pl: check defined(ENV variable) before using it Date: Tue, 8 Sep 2020 17:25:20 +0200 Message-Id: <20200908152250.297499295@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200908152241.646390211@linuxfoundation.org> References: <20200908152241.646390211@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap commit a73fbfce2cc28883f659414d598e6e60ca2214b4 upstream. A user reported: 'Use of uninitialized value $ENV{"LMC_KEEP"} in split at ./scripts/kconfig/streamline_config.pl line 596.' so first check that $ENV{LMC_KEEP} is defined before trying to use it. Fixes: c027b02d89fd ("streamline_config.pl: add LMC_KEEP to preserve some kconfigs") Signed-off-by: Randy Dunlap Acked-by: Steven Rostedt (VMware) Signed-off-by: Masahiro Yamada Signed-off-by: Greg Kroah-Hartman --- scripts/kconfig/streamline_config.pl | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/scripts/kconfig/streamline_config.pl +++ b/scripts/kconfig/streamline_config.pl @@ -593,7 +593,10 @@ while ($repeat) { } my %setconfigs; -my @preserved_kconfigs = split(/:/,$ENV{LMC_KEEP}); +my @preserved_kconfigs; +if (defined($ENV{'LMC_KEEP'})) { + @preserved_kconfigs = split(/:/,$ENV{LMC_KEEP}); +} sub in_preserved_kconfigs { my $kconfig = $config2kfile{$_[0]};