From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4E8AC43461 for ; Tue, 8 Sep 2020 19:25:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 650DD2076C for ; Tue, 8 Sep 2020 19:25:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="d5Ro0OR8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732154AbgIHTZy (ORCPT ); Tue, 8 Sep 2020 15:25:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731078AbgIHQAj (ORCPT ); Tue, 8 Sep 2020 12:00:39 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B79EDC06123D for ; Tue, 8 Sep 2020 08:26:49 -0700 (PDT) Received: from zn.tnic (p200300ec2f10bf00716ea70263de84d4.dip0.t-ipconnect.de [IPv6:2003:ec:2f10:bf00:716e:a702:63de:84d4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 6BF651EC0284; Tue, 8 Sep 2020 17:25:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1599578745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Tnjt7ngho1DKnqWxjc7ecHrXFfdKVeNz1CnHxEHCMvM=; b=d5Ro0OR8lEypRyNqOEG+7RqAkGUIpkToBaG9EcdUKiOm13l5E+i8kwKPebPqGcV/FWy7zR V9jaIgvktD5RJPSU9uPiSkdOLmdWBctfYF9CKhVB/uH/38SfNFRJ9XTk4tnYCKdaLIjcY3 PBwOnUOvN8Vt8gO7Y4CzFMRPclXBDs4= Date: Tue, 8 Sep 2020 17:25:39 +0200 From: Borislav Petkov To: "Luck, Tony" Cc: x86-ml , lkml Subject: Re: [RFC PATCH] x86/mce: Make mce_rdmsrl() do a plain RDMSR only Message-ID: <20200908152539.GE25236@zn.tnic> References: <20200906212130.GA28456@zn.tnic> <20200907200622.GA28517@agluck-desk2.amr.corp.intel.com> <20200908094650.GA25236@zn.tnic> <20200908100837.GC25236@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 08, 2020 at 03:07:05PM +0000, Luck, Tony wrote: > We can even get a nice diagnostic message since the handler > has access to "regs". It can print which MSR (regs->cx) and > where it happened (regs->ip). > > Which sounds like you might want a specific ex_handler_rdmsr > function rather than a generic ex_handler_panic. > > Maybe same deal for wrmsr() too? That would also print edx:eax > so you could see what was being written. Sounds good. Lemme try to come up with something these days. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette