From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBE1DC433E2 for ; Wed, 9 Sep 2020 08:46:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7785321919 for ; Wed, 9 Sep 2020 08:46:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730181AbgIIIq4 (ORCPT ); Wed, 9 Sep 2020 04:46:56 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:49220 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730158AbgIIIqr (ORCPT ); Wed, 9 Sep 2020 04:46:47 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id F21A51C0B87; Wed, 9 Sep 2020 10:46:43 +0200 (CEST) Date: Wed, 9 Sep 2020 10:46:43 +0200 From: Pavel Machek To: Dan Murphy Cc: Gene Chen , jacek.anaszewski@gmail.com, matthias.bgg@gmail.com, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, gene_chen@richtek.com, Wilma.Wu@mediatek.com, shufan_lee@richtek.com, cy_huang@richtek.com, benjamin.chao@mediatek.com Subject: Re: [PATCH 1/2] leds: mt6360: Add LED driver for MT6360 Message-ID: <20200909084643.GB10891@amd> References: <1598441840-15226-1-git-send-email-gene.chen.richtek@gmail.com> <1598441840-15226-2-git-send-email-gene.chen.richtek@gmail.com> <1b6e8bf7-fc11-542b-f570-cebb0b6c3442@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pvezYHf7grwyp3Bc" Content-Disposition: inline In-Reply-To: <1b6e8bf7-fc11-542b-f570-cebb0b6c3442@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --pvezYHf7grwyp3Bc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! >=20 > >@@ -271,6 +271,17 @@ config LEDS_MT6323 > > This option enables support for on-chip LED drivers found on > > Mediatek MT6323 PMIC. =2E..522 lines... > >+static int mt6360_init_isnk_properties(struct mt6360_led *led, struct l= ed_init_data *init_data) > >+{ > >+ struct led_classdev *isnk =3D &led->isnk; > >+ > >+ isnk->max_brightness =3D mt6360_get_isnk_max_level(led->led_no); > This function is called once seems a bit much to have a service function = for > a simple switch case. Please remove code you are not commenting on. That a) reduces bandwidth requirements but more importantly b) makes it easier to find your comments. Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --pvezYHf7grwyp3Bc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl9YlnMACgkQMOfwapXb+vLvDgCgi0jys/9Gg6FdVPAtrooeRyXJ TPMAoIHj0ruueSBPPi4OfU/aJK0VNp3O =kq07 -----END PGP SIGNATURE----- --pvezYHf7grwyp3Bc--