From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D7DDC10DAA for ; Wed, 9 Sep 2020 21:47:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1569206DB for ; Wed, 9 Sep 2020 21:47:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="IEhWgrJq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729413AbgIIVrV (ORCPT ); Wed, 9 Sep 2020 17:47:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728617AbgIIVrU (ORCPT ); Wed, 9 Sep 2020 17:47:20 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9FA3C061756 for ; Wed, 9 Sep 2020 14:47:19 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id 7so3022467pgm.11 for ; Wed, 09 Sep 2020 14:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=c43l4haQiH2l2U2Uxeo70dZHTihDun4B2/lN0CtMGwY=; b=IEhWgrJqh/LelmsUp+GmgJEU5D0S1P6HNMNZBzcEXC6OX2Dx8t0NbpWWroOPaEizt8 QZPjkLfGNCy/ErDM0TZ5G45/D4VzTiJtbc+qtSn2jPpuNKrwshlv18DwvAR7paKIMvWm BXeYdkGAu4F0iAY2x+UF6d9YO44ybeNtE7a3k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=c43l4haQiH2l2U2Uxeo70dZHTihDun4B2/lN0CtMGwY=; b=JIyg/FfR+3jyouAESxdDsenFlqs4ZlBPoML5eYH++zytjbybrnA946gQylYjdvZZDL +yPP5bkPsNzu0ZnFzM2RVcrtnVm6rxmt3Kjns8IjqAa4JDG4cN1Ekrz1LVHY/GoQDWMG 9LUIvLbRcJ5JfU1SMFPtZtbYPUwabFXuX0scfkD5vsqjZYtohDtYFX1EcHSfBUb1L1NM E7XwKXoz6ouJTJEOOdzLcLosHwtDvkWtfK3w1N9y3+Roq5YXlntnLIuabMnskv/DzJzI +h8UQSKM7zjRjDbHrFjIDGTKw3GXr9Jlmg8Hb2lqZ1J8eeWG7s6/9pT+OD7VxheOyRIx YI8g== X-Gm-Message-State: AOAM530K9qLESNIe/sW1JRMG9MgH8RNxzY8yn2flCj0jDwd+fQ6NgGvt TcdZOz+s7K9ac5PA4RmBSlgrrfq01lAx5wxV X-Google-Smtp-Source: ABdhPJwH76k4mk8b1qLtiU7RgZYntfKYanCipdXxCyld7g7uIy6GXrZvvmmLCeRPn0Xyz7dtTdV7tA== X-Received: by 2002:a62:150b:: with SMTP id 11mr2415164pfv.115.1599688039142; Wed, 09 Sep 2020 14:47:19 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u10sm3590464pfn.122.2020.09.09.14.47.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 14:47:18 -0700 (PDT) Date: Wed, 9 Sep 2020 14:47:17 -0700 From: Kees Cook To: Greg KH Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List Subject: Re: linux-next: build failure after merge of the driver-core tree Message-ID: <202009091446.806D39CB@keescook> References: <20200909154709.619fe9bb@canb.auug.org.au> <20200909072105.GA438160@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200909072105.GA438160@kroah.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 09, 2020 at 09:21:05AM +0200, Greg KH wrote: > On Wed, Sep 09, 2020 at 03:47:09PM +1000, Stephen Rothwell wrote: > > Hi all, > > > > After merging the driver-core tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > lib/test_firmware.c: In function 'trigger_request_platform_store': > > lib/test_firmware.c:517:35: error: 'efi_embedded_fw_list' undeclared (first use in this function); did you mean 'efi_embedded_fw_desc'? > > 517 | list_add(&efi_embedded_fw.list, &efi_embedded_fw_list); > > | ^~~~~~~~~~~~~~~~~~~~ > > | efi_embedded_fw_desc > > lib/test_firmware.c:517:35: note: each undeclared identifier is reported only once for each function it appears in > > lib/test_firmware.c:518:34: error: 'efi_embedded_fw_checked' undeclared (first use in this function); did you mean 'saved_efi_embedded_fw_checked'? > > 518 | saved_efi_embedded_fw_checked = efi_embedded_fw_checked; > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > | saved_efi_embedded_fw_checked > > > > Caused by commit > > > > 18efb2f9e897 ("test_firmware: Test platform fw loading on non-EFI systems") > > {sigh} > > I'll go revert this, sorry about that. > > Kees, can you fix up this whole series and resend it again? I'm > dropping it from my trees now... Oh ew, I will check the configs. I wonder what went wrong with this... sorry for the noise! -- Kees Cook