From: Rob Herring <robh@kernel.org>
To: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>,
devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
Fabien Dessenne <fabien.dessenne@st.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH 2/3] dt-bindings: remoteproc: stm32_rproc: update for firmware synchronization
Date: Wed, 9 Sep 2020 14:22:51 -0600 [thread overview]
Message-ID: <20200909202251.GA2975092@bogus> (raw)
In-Reply-To: <20200827072101.26588-3-arnaud.pouliquen@st.com>
On Thu, Aug 27, 2020 at 09:21:00AM +0200, Arnaud Pouliquen wrote:
> Add new properties description used to attach to a pre-loaded
> firmware according to the commit 9276536f455b3
> ("remoteproc: stm32: Parse syscon that will manage M4 synchronisation")
> which updates the driver part.
>
> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
> ---
> .../bindings/remoteproc/st,stm32-rproc.yaml | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
> index 4ffa25268fcc..e50957d86b1c 100644
> --- a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
> @@ -96,6 +96,25 @@ properties:
> 3rd cell: register bitmask for the deep sleep bit
> maxItems: 1
>
> + st,syscfg-m4-state:
> + $ref: "/schemas/types.yaml#/definitions/phandle-array"
> + description: |
> + Reference to the tamp register which exposes the Cortex-M4 state.
> + 1st cell: phandle to syscon block
> + 2nd cell: register offset containing the Cortex-M4 state
> + 3rd cell: register bitmask for the Cortex-M4 state
> + maxItems: 1
> +
> + st,syscfg-rsc-tbl:
> + $ref: "/schemas/types.yaml#/definitions/phandle-array"
> + description: |
> + Reference to the tamp register which references the Cortex-M4
> + resource table address.
> + 1st cell: phandle to syscon block
> + 2nd cell: register offset containing the resource table address
> + 3rd cell: register bitmask for the resource table address
> + maxItems: 1
Why can't these be implied? You can lookup the tamp syscon by
compatible.
Please add these to the example.
> +
> st,auto-boot:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-09-09 20:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 7:20 [PATCH 0/3] ARM: stm32: add DT properties for remote proc synchronisation Arnaud Pouliquen
2020-08-27 7:20 ` [PATCH 1/3] dt-bindings: arm: stm32: Add compatible for syscon tamp node Arnaud Pouliquen
2020-09-09 20:19 ` Rob Herring
2020-08-27 7:21 ` [PATCH 2/3] dt-bindings: remoteproc: stm32_rproc: update for firmware synchronization Arnaud Pouliquen
2020-09-09 20:22 ` Rob Herring [this message]
2020-09-11 13:49 ` Arnaud POULIQUEN
2020-09-23 14:30 ` Arnaud POULIQUEN
2020-08-27 7:21 ` [PATCH 3/3] ARM: dts: stm32: update stm32mp151 for remote proc synchronisation support Arnaud Pouliquen
2020-09-24 5:45 ` [Linux-stm32] " Ahmad Fatoum
2020-09-24 8:02 ` Arnaud POULIQUEN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909202251.GA2975092@bogus \
--to=robh@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=fabien.dessenne@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).