From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B414BC10DAA for ; Wed, 9 Sep 2020 21:43:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8340F21D7D for ; Wed, 9 Sep 2020 21:43:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729908AbgIIVnR (ORCPT ); Wed, 9 Sep 2020 17:43:17 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:53508 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726426AbgIIVnP (ORCPT ); Wed, 9 Sep 2020 17:43:15 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kG7rn-00Dyhc-B3; Wed, 09 Sep 2020 23:42:59 +0200 Date: Wed, 9 Sep 2020 23:42:59 +0200 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: netdev@vger.kernel.org, linux-leds@vger.kernel.org, Pavel Machek , Dan Murphy , =?utf-8?Q?Ond=C5=99ej?= Jirman , Russell King , linux-kernel@vger.kernel.org, Matthias Schiffer , "David S. Miller" Subject: Re: [PATCH net-next + leds v2 0/7] PLEASE REVIEW: Add support for LEDs on Marvell PHYs Message-ID: <20200909214259.GL3290129@lunn.ch> References: <20200909162552.11032-1-marek.behun@nic.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200909162552.11032-1-marek.behun@nic.cz> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 09, 2020 at 06:25:45PM +0200, Marek Behún wrote: > Hello Andrew and Pavel, > > please review these patches adding support for HW controlled LEDs. > The main difference from previous version is that the API is now generalized > and lives in drivers/leds, so that part needs to be reviewed (and maybe even > applied) by Pavel. > > As discussed previously between you two, I made it so that the devicename > part of the LED is now in the form `ethernet-phy%i` when the LED is probed > for an ethernet PHY. Userspace utility wanting to control LEDs for a specific > network interface can access them via /sys/class/net/eth0/phydev/leds: > > mox ~ # ls /sys/class/net/eth0/phydev/leds It is nice they are directly in /sys/class/net/eth0/phydev. Do they also appear in /sys/class/led? Have you played with network namespaces? What happens with ip netns add ns1 ip link set eth0 netns ns1 Andrew