From: Michal Hocko <mhocko@suse.com>
To: Laurent Dufour <ldufour@linux.ibm.com>
Cc: akpm@linux-foundation.org, David Hildenbrand <david@redhat.com>,
Oscar Salvador <osalvador@suse.de>,
rafael@kernel.org, nathanl@linux.ibm.com, cheloha@linux.ibm.com,
stable@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: don't rely on system state to detect hot-plug operations
Date: Thu, 10 Sep 2020 09:23:31 +0200 [thread overview]
Message-ID: <20200910072331.GB28354@dhcp22.suse.cz> (raw)
In-Reply-To: <74a62b00-235e-7deb-2814-f3b240fea25e@linux.ibm.com>
On Wed 09-09-20 18:07:15, Laurent Dufour wrote:
> Le 09/09/2020 à 12:59, Michal Hocko a écrit :
> > On Wed 09-09-20 11:21:58, Laurent Dufour wrote:
[...]
> > > For the point a, using the enum allows to know in
> > > register_mem_sect_under_node() if the link operation is due to a hotplug
> > > operation or done at boot time.
> >
> > Yes, but let me repeat. We have a mess here and different paths check
> > for the very same condition by different ways. We need to unify those.
>
> What are you suggesting to unify these checks (using a MP_* enum as
> suggested by David, something else)?
We do have system_state check spread at different places. I would use
this one and wrap it behind a helper. Or have I missed any reason why
that wouldn't work for this case?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-09-10 7:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5cbd92e1-c00a-4253-0119-c872bfa0f2bc@redhat.com>
[not found] ` <20200908170835.85440-1-ldufour@linux.ibm.com>
2020-09-09 7:40 ` [PATCH] mm: don't rely on system state to detect hot-plug operations Michal Hocko
2020-09-09 7:48 ` Laurent Dufour
2020-09-09 9:09 ` Michal Hocko
2020-09-09 9:21 ` Laurent Dufour
2020-09-09 9:24 ` David Hildenbrand
2020-09-09 9:32 ` Laurent Dufour
2020-09-09 12:30 ` Greg Kroah-Hartman
2020-09-09 12:32 ` David Hildenbrand
2020-09-09 12:36 ` Greg Kroah-Hartman
2020-09-09 12:45 ` Michal Hocko
2020-09-09 10:59 ` Michal Hocko
2020-09-09 16:07 ` Laurent Dufour
2020-09-10 7:23 ` Michal Hocko [this message]
2020-09-10 7:51 ` Laurent Dufour
2020-09-10 11:12 ` Michal Hocko
2020-09-10 11:35 ` Laurent Dufour
2020-09-10 12:00 ` David Hildenbrand
2020-09-10 12:36 ` Laurent Dufour
2020-09-10 12:38 ` David Hildenbrand
2020-09-10 12:01 ` Michal Hocko
2020-09-10 12:03 ` Oscar Salvador
2020-09-10 12:32 ` Laurent Dufour
2020-09-10 12:47 ` Michal Hocko
2020-09-10 12:48 ` Michal Hocko
2020-09-10 13:39 ` Oscar Salvador
2020-09-10 13:51 ` Michal Hocko
2020-09-10 14:40 ` Michal Hocko
2020-09-10 12:49 ` David Hildenbrand
2020-09-10 13:54 ` Michal Hocko
2020-09-10 13:57 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910072331.GB28354@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cheloha@linux.ibm.com \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nathanl@linux.ibm.com \
--cc=osalvador@suse.de \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).