From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Andrew Jeffery <andrew@aj.id.au>,
linux-hwmon@vger.kernel.org
Cc: lkp@intel.com, kbuild-all@lists.01.org, linux@roeck-us.net,
jdelvare@suse.com, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (pmbus) Expose PEC debugfs attribute
Date: Thu, 10 Sep 2020 13:05:16 +0300 [thread overview]
Message-ID: <20200910100516.GE12635@kadam> (raw)
In-Reply-To: <20200909132411.2906159-1-andrew@aj.id.au>
[-- Attachment #1: Type: text/plain, Size: 3106 bytes --]
Hi Andrew,
url: https://github.com/0day-ci/linux/commits/Andrew-Jeffery/hwmon-pmbus-Expose-PEC-debugfs-attribute/20200910-010642
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: x86_64-randconfig-m001-20200909 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/hwmon/pmbus/pmbus_core.c:2415 pmbus_debugfs_ops_pec_open() warn: '0x' prefix is confusing together with '%1llu' specifier
# https://github.com/0day-ci/linux/commit/705b8b5588d4102256d0954086ed16c9bdf9804f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Andrew-Jeffery/hwmon-pmbus-Expose-PEC-debugfs-attribute/20200910-010642
git checkout 705b8b5588d4102256d0954086ed16c9bdf9804f
vim +2415 drivers/hwmon/pmbus/pmbus_core.c
705b8b5588d410 Andrew Jeffery 2020-09-09 2391 static int pmbus_debugfs_set_pec(void *data, u64 val)
705b8b5588d410 Andrew Jeffery 2020-09-09 2392 {
705b8b5588d410 Andrew Jeffery 2020-09-09 2393 int rc;
705b8b5588d410 Andrew Jeffery 2020-09-09 2394 struct i2c_client *client = data;
705b8b5588d410 Andrew Jeffery 2020-09-09 2395
705b8b5588d410 Andrew Jeffery 2020-09-09 2396 if (!val) {
705b8b5588d410 Andrew Jeffery 2020-09-09 2397 client->flags &= ~I2C_CLIENT_PEC;
705b8b5588d410 Andrew Jeffery 2020-09-09 2398 return 0;
705b8b5588d410 Andrew Jeffery 2020-09-09 2399 }
705b8b5588d410 Andrew Jeffery 2020-09-09 2400
705b8b5588d410 Andrew Jeffery 2020-09-09 2401 if (val != 1)
705b8b5588d410 Andrew Jeffery 2020-09-09 2402 return -EINVAL;
705b8b5588d410 Andrew Jeffery 2020-09-09 2403
705b8b5588d410 Andrew Jeffery 2020-09-09 2404 rc = i2c_smbus_read_byte_data(client, PMBUS_CAPABILITY);
705b8b5588d410 Andrew Jeffery 2020-09-09 2405 if (rc < 0)
705b8b5588d410 Andrew Jeffery 2020-09-09 2406 return rc;
705b8b5588d410 Andrew Jeffery 2020-09-09 2407
705b8b5588d410 Andrew Jeffery 2020-09-09 2408 if (!(rc & PB_CAPABILITY_ERROR_CHECK))
705b8b5588d410 Andrew Jeffery 2020-09-09 2409 return -ENOTSUPP;
705b8b5588d410 Andrew Jeffery 2020-09-09 2410
705b8b5588d410 Andrew Jeffery 2020-09-09 2411 client->flags |= I2C_CLIENT_PEC;
705b8b5588d410 Andrew Jeffery 2020-09-09 2412
705b8b5588d410 Andrew Jeffery 2020-09-09 2413 return 0;
705b8b5588d410 Andrew Jeffery 2020-09-09 2414 }
705b8b5588d410 Andrew Jeffery 2020-09-09 @2415 DEFINE_DEBUGFS_ATTRIBUTE(pmbus_debugfs_ops_pec, pmbus_debugfs_get_pec,
705b8b5588d410 Andrew Jeffery 2020-09-09 2416 pmbus_debugfs_set_pec, "0x%1llu\n");
^^^^^^^
Was the 1 intentional? Anyway, you probably want to remove the 0x so
it doesn't look like hex.
705b8b5588d410 Andrew Jeffery 2020-09-09 2417
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49877 bytes --]
next prev parent reply other threads:[~2020-09-10 10:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 13:24 [PATCH] hwmon: (pmbus) Expose PEC debugfs attribute Andrew Jeffery
2020-09-09 15:31 ` Guenter Roeck
2020-09-10 2:12 ` Andrew Jeffery
2020-09-10 10:05 ` Dan Carpenter [this message]
2020-09-10 10:34 ` Guenter Roeck
2020-09-10 10:51 ` Andrew Jeffery
2020-09-10 13:32 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910100516.GE12635@kadam \
--to=dan.carpenter@oracle.com \
--cc=andrew@aj.id.au \
--cc=jdelvare@suse.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).