From: Kees Cook <keescook@chromium.org>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
Denis Efremov <efremov@linux.com>,
julia.lawall@inria.fr
Subject: Re: [PATCH] checkpatch: Warn on self-assignments
Date: Thu, 10 Sep 2020 12:51:08 -0700 [thread overview]
Message-ID: <202009101250.FBB416D@keescook> (raw)
In-Reply-To: <afc2cffdd315d3e4394af149278df9e8af7f49f4.camel@perches.com>
On Sat, Sep 05, 2020 at 10:58:29AM -0700, Joe Perches wrote:
> The uninitialized_var() macro was removed recently via
> commit 63a0895d960a ("compiler: Remove uninitialized_var() macro")
> as it's not a particularly useful warning and its use can
> "paper over real bugs".
>
> Add a checkpatch test to warn on self-assignments as a means
> to avoid compiler warnings and as a back-door mechanism to
> reproduce the old uninitialized_var macro behavior.
>
> Signed-off-by: Joe Perches <joe@perches.com>
I like it! :)
Can you add a section to code style and include a link in the checkpatch
warning to it? (Feel free to just reuse the text removed from
deprecated.rst)
--
Kees Cook
next prev parent reply other threads:[~2020-09-10 19:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 21:01 [RFC PATCH] coccinelle: misc: add uninitialized_var.cocci script Denis Efremov
2020-08-29 19:36 ` Julia Lawall
2020-08-29 19:38 ` Joe Perches
2020-08-29 19:48 ` Julia Lawall
2020-08-29 20:13 ` Denis Efremov
2020-08-29 20:26 ` Julia Lawall
2020-09-01 7:15 ` [PATCH v2] " Denis Efremov
2020-09-01 9:06 ` Julia Lawall
2020-09-01 9:48 ` [PATCH v3] " Denis Efremov
2020-09-01 10:08 ` Julia Lawall
2020-09-01 14:37 ` checkpatch? (was: Re: [PATCH v3] coccinelle: misc: add uninitialized_var.cocci script) Joe Perches
2020-09-02 5:17 ` Denis Efremov
2020-09-05 17:18 ` [PATCH v3] coccinelle: misc: add uninitialized_var.cocci script Julia Lawall
2020-09-05 17:58 ` [PATCH] checkpatch: Warn on self-assignments Joe Perches
2020-09-10 19:51 ` Kees Cook [this message]
2020-09-10 21:35 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202009101250.FBB416D@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=cocci@systeme.lip6.fr \
--cc=efremov@linux.com \
--cc=gustavoars@kernel.org \
--cc=joe@perches.com \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).