From: Jon Hunter <jonathanh@nvidia.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>
Cc: <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
Jon Hunter <jonathanh@nvidia.com>
Subject: [PATCH 3/5] misc: eeprom: at24: Support custom device names for AT24 EEPROMs
Date: Thu, 10 Sep 2020 14:42:37 +0100 [thread overview]
Message-ID: <20200910134239.192030-4-jonathanh@nvidia.com> (raw)
In-Reply-To: <20200910134239.192030-1-jonathanh@nvidia.com>
By using the label property, a more descriptive name can be populated
for AT24 EEPROMs NVMEM device. Update the AT24 driver to check to see
if the label property is present and if so, use this as the name for
NVMEM device.
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
drivers/misc/eeprom/at24.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 3f7a3bb6a36c..058be08a9a40 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -713,7 +713,15 @@ static int at24_probe(struct i2c_client *client)
return err;
}
- nvmem_config.name = dev_name(dev);
+ if (device_property_present(dev, "label")) {
+ err = device_property_read_string(dev, "label",
+ &nvmem_config.name);
+ if (err)
+ return err;
+ } else {
+ nvmem_config.name = dev_name(dev);
+ }
+
nvmem_config.dev = dev;
nvmem_config.id = NVMEM_DEVID_NONE;
nvmem_config.read_only = !writable;
--
2.25.1
next prev parent reply other threads:[~2020-09-10 21:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 13:42 [PATCH 0/5] Add support for custom names for AT24 EEPROMs Jon Hunter
2020-09-10 13:42 ` [PATCH 1/5] misc: eeprom: at24: Initialise AT24 NVMEM ID field Jon Hunter
2020-09-10 15:35 ` Bartosz Golaszewski
2020-09-10 18:15 ` Jon Hunter
2020-09-10 18:19 ` Jon Hunter
2020-09-11 7:45 ` Bartosz Golaszewski
2020-09-10 13:42 ` [PATCH 2/5] dt-bindings: eeprom: at24: Add label property for AT24 Jon Hunter
2020-09-15 20:25 ` Rob Herring
2020-09-10 13:42 ` Jon Hunter [this message]
2020-09-10 13:42 ` [PATCH 4/5] arm64: tegra: Add label properties for EEPROMs Jon Hunter
2020-09-10 13:42 ` [PATCH 5/5] arm64: tegra: Populate EEPROMs for Jetson Xavier NX Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910134239.192030-4-jonathanh@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).