From: Rich Felker <dalias@libc.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfs: add fchmodat2 syscall
Date: Thu, 10 Sep 2020 11:45:17 -0400 [thread overview]
Message-ID: <20200910154516.GH3265@brightrain.aerifal.cx> (raw)
In-Reply-To: <20200910151828.GD1236603@ZenIV.linux.org.uk>
On Thu, Sep 10, 2020 at 04:18:28PM +0100, Al Viro wrote:
> On Thu, Sep 10, 2020 at 10:23:37AM -0400, Rich Felker wrote:
>
> > It was determined (see glibc issue #14578 and commit a492b1e5ef) that,
> > on some filesystems, performing chmod on the link itself produces a
> > change in the inode's access mode, but returns an EOPNOTSUPP error.
>
> Which filesystem types are those?
It's been a long time and I don't know if the details were recorded.
It was reported for xfs but I believe we later found it happening for
others. See:
https://sourceware.org/bugzilla/show_bug.cgi?id=14578#c17
https://sourceware.org/legacy-ml/libc-alpha/2020-02/msg00467.html
and especially:
https://sourceware.org/legacy-ml/libc-alpha/2020-02/msg00518.html
where Christoph seems to have endorsed the approach in my patch. I'm
fine with doing it differently if you'd prefer, though.
Rich
next prev parent reply other threads:[~2020-09-10 19:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 14:23 [PATCH] vfs: add fchmodat2 syscall Rich Felker
2020-09-10 15:18 ` Al Viro
2020-09-10 15:45 ` Rich Felker [this message]
2020-09-10 15:23 ` David Laight
2020-09-10 16:16 ` Greg KH
2020-09-10 16:35 ` Rich Felker
2020-09-10 16:20 ` Christoph Hellwig
2020-09-10 16:39 ` Rich Felker
2020-09-10 16:42 ` Christoph Hellwig
2020-09-10 17:02 ` Rich Felker
2020-09-11 6:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910154516.GH3265@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).