From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73607C43461 for ; Thu, 10 Sep 2020 23:06:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3907320882 for ; Thu, 10 Sep 2020 23:06:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gSNaWPdE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725446AbgIJXGr (ORCPT ); Thu, 10 Sep 2020 19:06:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725280AbgIJXGn (ORCPT ); Thu, 10 Sep 2020 19:06:43 -0400 Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE8E8C061756 for ; Thu, 10 Sep 2020 16:06:42 -0700 (PDT) Received: by mail-qt1-x842.google.com with SMTP id p65so6312683qtd.2 for ; Thu, 10 Sep 2020 16:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NDyjd2iMqequc7LRMcRbG7To5TWvVyedy/KOdmHGA9k=; b=gSNaWPdEY2QnZcjph+epkQoIRckMJ874n0EFerBdUUjyUl30uIWC34VWoHykoJjQ2E LN6wVH8yVGRLppCxyuiY0kt80KWFDFQiTkmaSgmu+hAuWpTiNqVNLOP8xx0sm3oagMAK LS3rYYs5b0CjLr4QYfdFymg1HeGqT4gMXc/0KpHr6N7uvpfAqSB4j7t78+WfK6eBcu6R TNXKjNwS/tZ/jQ8dslR7h8Wx51Mbm4uE7jjsvWar+SQ4a1TA3Yk1hP+zwMFH0HhgCVIr lDdfV7C3fE7uYZh82uHb5FyEvrmCINbklup9YkD6ZmBLHnkbyLW+++sR1/UOpvP+1LPq 3DHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NDyjd2iMqequc7LRMcRbG7To5TWvVyedy/KOdmHGA9k=; b=HkUGjNm1JYYW8/YTdLe6kw2bC4rCNRv7UCW2KHxdncSBOZcegh9bKOZtQYW3Ua5tsz ZFRwMAvfetUSd2hhO1ZYcPT9KmlkB8wsEgoUgCi1xAiIc2UI0zb4OIwRbioebz6dCqj4 rgPMMZpnHFzbfosYEv11ca+708cxtXa7CBrFS4ylv8E7+bHf+BtibeWWefE4JzlmD43n L7t7G1utgb9nBB1vVzH5WxPd2Sd3hOxgMEubM+5shIl41NT3RTBXzyOFbbOL53gndhej wqAbkDdGlROkndAzcYis9WvcoqDF1GIYjPWgdPLd/+H/NXVrpN6cVcmAc3TjQLa57wIa L0cQ== X-Gm-Message-State: AOAM533KMHXFQ/ntLaYw5UPdNqvEWoepZRCi0Uu86UkD049eNN/BLt/4 Ro91Begt4glrXj2hldgp3SX5ww== X-Google-Smtp-Source: ABdhPJwUNn1cTdcJJNctsCsTgJWF1pa/DKRujT7/DrPwH/+LKqQh/m6CHBbRIBeoyfdun9zY14Czpw== X-Received: by 2002:ac8:7188:: with SMTP id w8mr3165127qto.134.1599779201381; Thu, 10 Sep 2020 16:06:41 -0700 (PDT) Received: from uller (ec2-34-197-84-77.compute-1.amazonaws.com. [34.197.84.77]) by smtp.gmail.com with ESMTPSA id u55sm288593qtu.42.2020.09.10.16.06.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2020 16:06:40 -0700 (PDT) Date: Thu, 10 Sep 2020 23:06:39 +0000 From: Bjorn Andersson To: satya priya , gregkh@linuxfoundation.org Cc: Matthias Kaehlcke , Andy Gross , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, akashast@codeaurora.org, rojay@codeaurora.org, msavaliy@qti.qualcomm.com, dianders@chromium.org Subject: Re: [PATCH V5 4/4] tty: serial: qcom_geni_serial: Fix the UART wakeup issue Message-ID: <20200910230639.GB472@uller> References: <1599742438-16811-1-git-send-email-skakit@codeaurora.org> <1599742438-16811-5-git-send-email-skakit@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1599742438-16811-5-git-send-email-skakit@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 10 Sep 12:53 UTC 2020, satya priya wrote: > As a part of system suspend uart_port_suspend is called from the > Serial driver, which calls set_mctrl passing mctrl as 0. This > makes RFR high(NOT_READY) during suspend. > > Due to this BT SoC is not able to send wakeup bytes to UART during > suspend. Include if check for non-suspend case to keep RFR low > during suspend. > Seems reasonable. Reviewed-by: Bjorn Andersson > Signed-off-by: satya priya > Acked-by: Greg Kroah-Hartman Greg, I don't see this depending on anything else, will you pick this patch through your tree? I will take the dts patches through the qcom tree. Regards, Bjorn > Reviewed-by: Akash Asthana > --- > Changes in V2: > - This patch fixes the UART flow control issue during suspend. > Newly added in V2. > > Changes in V3: > - As per Matthias's comment removed the extra parentheses. > > Changes in V4: > - No change. > > Changes in V5: > - As per Matthias comment, fixed nit-pick in commit text. > > drivers/tty/serial/qcom_geni_serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c > index 3aa29d2..bc63c54 100644 > --- a/drivers/tty/serial/qcom_geni_serial.c > +++ b/drivers/tty/serial/qcom_geni_serial.c > @@ -242,7 +242,7 @@ static void qcom_geni_serial_set_mctrl(struct uart_port *uport, > if (mctrl & TIOCM_LOOP) > port->loopback = RX_TX_CTS_RTS_SORTED; > > - if (!(mctrl & TIOCM_RTS)) > + if (!(mctrl & TIOCM_RTS) && !uport->suspended) > uart_manual_rfr = UART_MANUAL_RFR_EN | UART_RFR_NOT_READY; > writel(uart_manual_rfr, uport->membase + SE_UART_MANUAL_RFR); > } > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation >