From: Xu Yilun <yilun.xu@intel.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: mdf@kernel.org, linux-kernel@vger.kernel.org, trix@redhat.com,
matthew.gerlach@linux.intel.com, russell.h.weight@intel.com,
lgoncalv@redhat.com, hao.wu@intel.com, yilun.xu@intel.com
Subject: Re: [PATCH] memory: dfl-emif: add the DFL EMIF private feature driver
Date: Fri, 11 Sep 2020 16:42:34 +0800 [thread overview]
Message-ID: <20200911084234.GB7802@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <20200908100102.GB24693@pi3>
Sorry I missed one comments, see inline.
On Tue, Sep 08, 2020 at 12:01:02PM +0200, Krzysztof Kozlowski wrote:
> On Tue, Sep 08, 2020 at 04:27:25PM +0800, Xu Yilun wrote:
> > This driver is for the EMIF private feature implemented under FPGA
> > Device Feature List (DFL) framework. It is used to expose memory
> > interface status information as well as memory clearing control.
> >
> > The purpose of memory clearing block is to zero out all private memory
> > when FPGA is to be reprogrammed. This gives users a reliable method to
> > prevent potential data leakage.
> >
> > Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> > Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> > ---
> > .../ABI/testing/sysfs-bus-dfl-devices-emif | 25 +++
> > drivers/memory/Kconfig | 9 +
> > drivers/memory/Makefile | 2 +
> > drivers/memory/dfl-emif.c | 211 +++++++++++++++++++++
> > 4 files changed, 247 insertions(+)
> > create mode 100644 Documentation/ABI/testing/sysfs-bus-dfl-devices-emif
> > create mode 100644 drivers/memory/dfl-emif.c
> >
> > diff --git a/Documentation/ABI/testing/sysfs-bus-dfl-devices-emif b/Documentation/ABI/testing/sysfs-bus-dfl-devices-emif
> > new file mode 100644
> > index 0000000..33d557e
> > --- /dev/null
> > +++ b/Documentation/ABI/testing/sysfs-bus-dfl-devices-emif
> > @@ -0,0 +1,25 @@
> > +What: /sys/bus/dfl/devices/dfl_dev.X/infX_cal_fail
> > +Date: Sep 2020
> > +KernelVersion: 5.10
> > +Contact: Xu Yilun <yilun.xu@intel.com>
> > +Description: Read-only. It indicates if the calibration is failed on this
> > + memory interface. "1" for calibration failure, "0" for OK.
>
> "if the calibration failed"
>
> > + Format: %u
> > +
> > +What: /sys/bus/dfl/devices/dfl_dev.X/infX_init_done
> > +Date: Sep 2020
> > +KernelVersion: 5.10
> > +Contact: Xu Yilun <yilun.xu@intel.com>
> > +Description: Read-only. It indicates if the initialization is complete on
> > + this memory interface. "1" for initialization complete, "0"
> > + for not yet.
> > + Format: %u
>
> "if the initialization completed"
>
> > +
> > +What: /sys/bus/dfl/devices/dfl_dev.X/infX_clear
> > +Date: Sep 2020
> > +KernelVersion: 5.10
> > +Contact: Xu Yilun <yilun.xu@intel.com>
> > +Description: Write-only. Writing "1" to this file will zero out all memory
> > + data in this memory interface. Writing other values are
> > + invalid.
>
> "Writing of other values is invalid."
>
> > + Format: %u
> > diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> > index 8072204..fb0858f 100644
> > --- a/drivers/memory/Kconfig
> > +++ b/drivers/memory/Kconfig
> > @@ -215,6 +215,15 @@ config STM32_FMC2_EBI
> > devices (like SRAM, ethernet adapters, FPGAs, LCD displays, ...) on
> > SOCs containing the FMC2 External Bus Interface.
> >
> > +config FPGA_DFL_EMIF
> > + tristate "DFL EMIF private feature support"
> > + depends on FPGA_DFL && HAS_IOMEM
>
> Cannot be compile tested without FPGA_DFL?
We need this FPGA_DFL dependency. The driver will use the
__dfl_driver_register(), which is defined in drivers/fpga/dfl.c, and
FPGA_DFL enables the compiling of dfl.c
Thanks,
Yilun
next prev parent reply other threads:[~2020-09-11 8:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 8:27 [PATCH] add the FPGA Device Feature List (DFL) EMIF support Xu Yilun
2020-09-08 9:03 ` Krzysztof Kozlowski
2020-09-09 7:45 ` Xu Yilun
[not found] ` <1599553645-26928-2-git-send-email-yilun.xu@intel.com>
2020-09-08 10:01 ` [PATCH] memory: dfl-emif: add the DFL EMIF private feature driver Krzysztof Kozlowski
2020-09-11 8:42 ` Xu Yilun [this message]
2020-09-11 9:03 ` Krzysztof Kozlowski
[not found] ` <20200911144356.GA11294@yilunxu-OptiPlex-7050>
2020-09-11 15:16 ` Krzysztof Kozlowski
2020-09-11 16:13 ` Wu, Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911084234.GB7802@yilunxu-OptiPlex-7050 \
--to=yilun.xu@intel.com \
--cc=hao.wu@intel.com \
--cc=krzk@kernel.org \
--cc=lgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=mdf@kernel.org \
--cc=russell.h.weight@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).