From: Mark Brown <broonie@kernel.org>
To: kuldip dwivedi <kuldip.dwivedi@puresoftware.com>
Cc: Ashish Kumar <ashish.kumar@nxp.com>,
Yogesh Gaur <yogeshgaur.83@gmail.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Varun Sethi <V.Sethi@nxp.com>, Arokia Samy <arokia.samy@nxp.com>,
Ard Biesheuvel <Ard.Biesheuvel@arm.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
Paul Yang <Paul.Yang@arm.com>
Subject: Re: [PATCH v2] spi: spi-nxp-fspi: Add ACPI support
Date: Fri, 11 Sep 2020 12:00:18 +0100 [thread overview]
Message-ID: <20200911110018.GD4895@sirena.org.uk> (raw)
In-Reply-To: <20200911082806.115-1-kuldip.dwivedi@puresoftware.com>
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
On Fri, Sep 11, 2020 at 01:58:06PM +0530, kuldip dwivedi wrote:
> /* find the resources - configuration register address space */
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "fspi_base");
> +#ifdef CONFIG_ACPI
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +#endif
This is buggy, it is equivalent to just removing the name based lookup
since we'll do the name based lookup then unconditionally overwrite the
results with an index based lookup.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-11 11:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 8:28 [PATCH v2] spi: spi-nxp-fspi: Add ACPI support kuldip dwivedi
2020-09-11 11:00 ` Mark Brown [this message]
2020-09-11 11:16 ` Ard Biesheuvel
2020-09-11 12:02 ` Kuldip Dwivedi
2020-09-11 12:17 ` Mark Brown
2020-09-11 12:28 ` [EXT] " Ashish Kumar
2020-09-11 12:34 ` Mark Brown
2020-09-11 13:32 ` Ashish Kumar
2020-09-15 6:52 ` Kuldip Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911110018.GD4895@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Ard.Biesheuvel@arm.com \
--cc=Paul.Yang@arm.com \
--cc=Samer.El-Haj-Mahmoud@arm.com \
--cc=V.Sethi@nxp.com \
--cc=arokia.samy@nxp.com \
--cc=ashish.kumar@nxp.com \
--cc=kuldip.dwivedi@puresoftware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=yogeshgaur.83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).