From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74F25C43461 for ; Fri, 11 Sep 2020 17:35:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36F29221E7 for ; Fri, 11 Sep 2020 17:35:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599845758; bh=q5AMvphCxcmQP1H/0lgF/CoRmF8mzY/oFlElmY/dmv4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jnAcABPOJTP4RHZ6ahkjFCYDySe892+AFO6pA/5z0/43FhbOZEwm7YSjrsWkJpcMN eYpiuj0+J06TScP/7dSFRfhpwEM3tYIqBRtNffCtaAIjZlTdizeuQB/kz9ZL/t40b7 q+/Gorh5mXdGTeGNhMXEQtF4+1lU//PH3hA+Rynk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726342AbgIKRfz (ORCPT ); Fri, 11 Sep 2020 13:35:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:49206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbgIKMye (ORCPT ); Fri, 11 Sep 2020 08:54:34 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1D98F2220A; Fri, 11 Sep 2020 12:53:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599828813; bh=q5AMvphCxcmQP1H/0lgF/CoRmF8mzY/oFlElmY/dmv4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gPEC023Vr/vTYUnsRLN4twMUZ9/iZVFxYufDbuhVXPYlx7qW4UH6nK9wUiqxa5axE OJHjbAXR5DyAkk2fXQzxUe+4EtDJp3Zc0m4xfwtp3njUnpzFqSL5YFneN5omErZZ3A g2h22WU/bTLON6vFPbhJuEq4+7g+0QgkXeUtHXbk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marc Zyngier , Al Viro , Sasha Levin Subject: [PATCH 4.4 17/62] fix regression in "epoll: Keep a reference on files added to the check list" Date: Fri, 11 Sep 2020 14:46:00 +0200 Message-Id: <20200911122503.245259147@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200911122502.395450276@linuxfoundation.org> References: <20200911122502.395450276@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Al Viro [ Upstream commit 77f4689de17c0887775bb77896f4cc11a39bf848 ] epoll_loop_check_proc() can run into a file already committed to destruction; we can't grab a reference on those and don't need to add them to the set for reverse path check anyway. Tested-by: Marc Zyngier Fixes: a9ed4a6560b8 ("epoll: Keep a reference on files added to the check list") Signed-off-by: Al Viro Signed-off-by: Sasha Levin --- fs/eventpoll.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index b8959d0d4c723..e5324642023d6 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -1720,9 +1720,9 @@ static int ep_loop_check_proc(void *priv, void *cookie, int call_nests) * during ep_insert(). */ if (list_empty(&epi->ffd.file->f_tfile_llink)) { - get_file(epi->ffd.file); - list_add(&epi->ffd.file->f_tfile_llink, - &tfile_check_list); + if (get_file_rcu(epi->ffd.file)) + list_add(&epi->ffd.file->f_tfile_llink, + &tfile_check_list); } } } -- 2.25.1