From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B789C433E2 for ; Fri, 11 Sep 2020 14:59:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 51C48223BD for ; Fri, 11 Sep 2020 14:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599836380; bh=4BrAkly75xff2zeo4WjU3QguBwgx00EVmX1ImTV5x/Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=G4xqjmpio6RsKkEsWicctvWyxv+oByDLIKtjJWQzN8V5hedvrzbYSuPq5+ah6i2Mj lMuff1WcN4NfytJa8ZP1HR9LvS35p+2jnnIUgcYcZ9E6pdPUSVG8qALc3GCVLjNmsp jifybCn8rmioeoqcojKRfRpFGTBY7UNlOyqXLzVY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726242AbgIKO7i (ORCPT ); Fri, 11 Sep 2020 10:59:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:52784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726172AbgIKNCU (ORCPT ); Fri, 11 Sep 2020 09:02:20 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 882F420758; Fri, 11 Sep 2020 12:57:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599829048; bh=4BrAkly75xff2zeo4WjU3QguBwgx00EVmX1ImTV5x/Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qeq5+UpzvVcm/1UoujyBkOgFBKhftoVvdwIZnhNXgVon1K1oO3H0rRKr+EFi0irwl UWW9YzmOIUJmj6r0fHjnL0YIfumfX5i49mwN/izry2iwu3lOOrbtM3nTboYoDh+GKZ vZrDNQGRPlCL6ugWjzjcty3mbotgg0bv9fH1wT18= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ye Bin , Mike Snitzer Subject: [PATCH 4.9 46/71] dm cache metadata: Avoid returning cmd->bm wild pointer on error Date: Fri, 11 Sep 2020 14:46:30 +0200 Message-Id: <20200911122507.216504913@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200911122504.928931589@linuxfoundation.org> References: <20200911122504.928931589@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ye Bin commit d16ff19e69ab57e08bf908faaacbceaf660249de upstream. Maybe __create_persistent_data_objects() caller will use PTR_ERR as a pointer, it will lead to some strange things. Signed-off-by: Ye Bin Cc: stable@vger.kernel.org Signed-off-by: Mike Snitzer Signed-off-by: Greg Kroah-Hartman --- drivers/md/dm-cache-metadata.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- a/drivers/md/dm-cache-metadata.c +++ b/drivers/md/dm-cache-metadata.c @@ -508,12 +508,16 @@ static int __create_persistent_data_obje CACHE_MAX_CONCURRENT_LOCKS); if (IS_ERR(cmd->bm)) { DMERR("could not create block manager"); - return PTR_ERR(cmd->bm); + r = PTR_ERR(cmd->bm); + cmd->bm = NULL; + return r; } r = __open_or_format_metadata(cmd, may_format_device); - if (r) + if (r) { dm_block_manager_destroy(cmd->bm); + cmd->bm = NULL; + } return r; }