From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64A27C433E2 for ; Sun, 13 Sep 2020 02:32:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0CD0420731 for ; Sun, 13 Sep 2020 02:32:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599964328; bh=6QjRX2df8XaG6kRVKUKdd183lBDC+CGc81pBPbkOMQk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Gr5khBcuC7OQtjwNn0JTWba8ulZGuzeJBBOnMO8FUyB55TkA11HV3b6EAV7JZRPZ0 YkigCk+30oC0LqAtF7hu1+foY/LIIUAAcaQn9m15EbHm/s/4RG129fmbo+iiFPqbes pg/YA6du1oRuFhH5VbpnZrJiS+24LJxuXt4WynE4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725954AbgIMCcG (ORCPT ); Sat, 12 Sep 2020 22:32:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:59626 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725907AbgIMCcD (ORCPT ); Sat, 12 Sep 2020 22:32:03 -0400 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A8C720731; Sun, 13 Sep 2020 02:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599964321; bh=6QjRX2df8XaG6kRVKUKdd183lBDC+CGc81pBPbkOMQk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QD/tNThepmuXKvQkvCRrBMfL8tXd39C2aw4PoHK0s9I6VJEOCSxOeqN0hITpgfh8C vVae/kU7BXjMlz1p7mltgd+RZQWhhtKbM62mK+UA3O83DT/J5LX82BviKgw75IUli3 PFqipygVt2ahoOYy0m6PWLbJH91M6Uc9/NGVvGco= Date: Sun, 13 Sep 2020 10:31:53 +0800 From: Shawn Guo To: Krzysztof Kozlowski , Tim Harvey Cc: Rob Herring , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Heiko Stuebner , Michal Simek , Adam Ford , Daniel Baluta , Anson Huang , Robin Gong , Alifer Moraes , Leonard Crestez , "Angus Ainslie (Purism)" , Vitor Massaru Iha , Kever Yang , Rajan Vaja , Anurag Kumar Vulisha , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 1/8] ARM: dts: imx6qdl: Correct interrupt flags in examples Message-ID: <20200913023152.GH25109@dragon> References: <20200908150241.5771-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200908150241.5771-1-krzk@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add Tim who is the board owner. On Tue, Sep 08, 2020 at 05:02:34PM +0200, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE > 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING > > Correct the interrupt flags, assuming the author of the code wanted some > logical behavior behind the name "ACTIVE_xxx", this is: > ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW > > Signed-off-by: Krzysztof Kozlowski The subject prefix could be a bit more specific, like 'ARM: dts: imx6qdl-gw5xxx'. Also, I do not quite understand meaning of 'in examples' in subject. Shawn > > --- > > Not tested on HW. > --- > arch/arm/boot/dts/imx6qdl-gw51xx.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw52xx.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw53xx.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw551x.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw552x.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw553x.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw5903.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw5904.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw5907.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw5910.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw5912.dtsi | 3 ++- > arch/arm/boot/dts/imx6qdl-gw5913.dtsi | 3 ++- > 14 files changed, 28 insertions(+), 14 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi > index 4d01c3300b97..3c04b5a4f3cb 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw51xx.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -152,7 +153,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi > index f6182a9d201c..736074f1c3ef 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw52xx.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -217,7 +218,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi > index a28e79463d0c..8072ed47c6bb 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -210,7 +211,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi > index 55f368e192c0..8c9bcdd39830 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > #include > > / { > @@ -247,7 +248,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #address-cells = <1>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi > index 1516e2b0bcde..e5d803d023c8 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi > @@ -48,6 +48,7 @@ > #include > #include > #include > +#include > #include > > / { > @@ -219,7 +220,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw552x.dtsi b/arch/arm/boot/dts/imx6qdl-gw552x.dtsi > index 0da6e6f7482b..290a607fede9 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw552x.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw552x.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -144,7 +145,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw553x.dtsi b/arch/arm/boot/dts/imx6qdl-gw553x.dtsi > index faf9a3ba61b2..c15b9cc63bf8 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw553x.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw553x.dtsi > @@ -47,6 +47,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -180,7 +181,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi > index f68f9dada5b0..093a219a77ae 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi > @@ -47,6 +47,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -294,7 +295,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw5903.dtsi b/arch/arm/boot/dts/imx6qdl-gw5903.dtsi > index fbe6c32bd756..e1c8dd233cab 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw5903.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw5903.dtsi > @@ -47,6 +47,7 @@ > > #include > #include > +#include > > / { > chosen { > @@ -235,7 +236,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw5904.dtsi b/arch/arm/boot/dts/imx6qdl-gw5904.dtsi > index 23c6e4047621..3cd2e717c1da 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw5904.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw5904.dtsi > @@ -47,6 +47,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -257,7 +258,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw5907.dtsi b/arch/arm/boot/dts/imx6qdl-gw5907.dtsi > index b1ff7c859c4d..21c68a55bcb9 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw5907.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw5907.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -154,7 +155,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw5910.dtsi b/arch/arm/boot/dts/imx6qdl-gw5910.dtsi > index 6c943a517ad7..ed4e22259959 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw5910.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw5910.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -163,7 +164,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw5912.dtsi b/arch/arm/boot/dts/imx6qdl-gw5912.dtsi > index 441d8ce97aa4..797f160249f7 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw5912.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw5912.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -158,7 +159,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #address-cells = <1>; > diff --git a/arch/arm/boot/dts/imx6qdl-gw5913.dtsi b/arch/arm/boot/dts/imx6qdl-gw5913.dtsi > index d62a8da49367..4cd7d290f5b2 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw5913.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw5913.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > > / { > /* these are used by bootloader for disabling nodes */ > @@ -139,7 +140,7 @@ > compatible = "gw,gsc"; > reg = <0x20>; > interrupt-parent = <&gpio1>; > - interrupts = <4 GPIO_ACTIVE_LOW>; > + interrupts = <4 IRQ_TYPE_LEVEL_LOW>; > interrupt-controller; > #interrupt-cells = <1>; > #size-cells = <0>; > -- > 2.17.1 >