From: Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>
To: kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
andriy.shevchenko@linux.intel.com,
vadivel.muruganx.ramuthevar@linux.intel.com,
eswara.kota@linux.intel.com,
lakshmi.bai.raja.subramanian@intel.com,
wan.ahmad.zainie.wan.mohamad@intel.com
Subject: [PATCH v9 0/3] phy: intel: Add Keem Bay eMMC PHY support
Date: Mon, 14 Sep 2020 07:55:19 +0800 [thread overview]
Message-ID: <20200913235522.4316-1-wan.ahmad.zainie.wan.mohamad@intel.com> (raw)
Hi.
The first patch is added to rename rename
phy-intel-{combo,emmc}.c to phy-intel-lgm-{combo,emmc}.c.
The second patch is to document DT bindings for Keem Bay eMMC PHY.
The the third is the driver file, loosely based on phy-rockchip-emmc.c
and phy-intel-emmc.c. The latter is not being reused as there are
quite a number of differences i.e. registers offset, supported clock
rates, bitfield to set.
The patch was tested with Keem Bay evaluation module board.
Thank you.
Best regards,
Zainie
Changes since v8:
- Amend Reviewed-by tag to single line.
- Add DT bindings for Keem Bay eMMC PHY into lgm eMMC PHY DT bindings
document.
Changes since v7:
- Add Reviewed-by tag to 1st (Vadivel) and 3rd patch (Andy).
- In 3rd patch,
- remove maskval and use FIELD_PREP instead,
- add <linux/bitfield.h> header,
- use return dev_err_probe(...) for devm_phy_create(...),
- rearrange depends on in Kconfig file,
Changes since v6:
- Add new patch to rename phy-intel-{combo,emmc}.c to
phy-intel-lgm-{combo,emmc}.c.
- Add Reviewed-by: Rob Herring <robh@kernel.org> tag to 2nd patch.
- In 3rd patch,
- add and use generic helper to update register bits,
- end module name with .ko in Kconfig help.
Changes since resend v5:
- In keembay_emmc_phy_power(), remove redundant return ret;.
Resend v5:
- Include missing changes done for phy-keembay-emmc.c (See Changes since
v3)
Changes since v4:
- In Kconfig file, add depends on ARM64 || COMPILE_TEST and
depends on OF && HAS_IOMEM.
- In Kconfig file, reword the help section to be more verbose.
Changes since v3:
- Exit keembay_emmc_phy_power() with return ret;.
- In keembay_emmc_phy_init(), use PTR_ERR_OR_ZERO(...).
- In keembay_emmc_phy_probe(), devm_regmap_init_mmio(...) in single
line.
Changes since v2:
- Modify DT example to use single cell for address and size.
Changes since v1:
- Rework phy-keembay-emmc.c to make it similar to phy-intel-emmc.c.
- Use regmap_mmio, and remove reference to intel,syscon.
- Use node name phy@....
- Update license i.e. use dual license.
*** BLURB HERE ***
Wan Ahmad Zainie (3):
phy: intel: Rename phy-intel to phy-intel-lgm
dt-bindings: phy: intel: Add Keem Bay eMMC PHY bindings
phy: intel: Add Keem Bay eMMC PHY support
.../bindings/phy/intel,lgm-emmc-phy.yaml | 17 +-
drivers/phy/intel/Kconfig | 22 +-
drivers/phy/intel/Makefile | 5 +-
drivers/phy/intel/phy-intel-keembay-emmc.c | 307 ++++++++++++++++++
...hy-intel-combo.c => phy-intel-lgm-combo.c} | 0
...{phy-intel-emmc.c => phy-intel-lgm-emmc.c} | 0
6 files changed, 343 insertions(+), 8 deletions(-)
create mode 100644 drivers/phy/intel/phy-intel-keembay-emmc.c
rename drivers/phy/intel/{phy-intel-combo.c => phy-intel-lgm-combo.c} (100%)
rename drivers/phy/intel/{phy-intel-emmc.c => phy-intel-lgm-emmc.c} (100%)
--
2.17.1
next reply other threads:[~2020-09-13 23:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-13 23:55 Wan Ahmad Zainie [this message]
2020-09-13 23:55 ` [PATCH v9 1/3] phy: intel: Rename phy-intel to phy-intel-lgm Wan Ahmad Zainie
2020-09-13 23:55 ` [PATCH v9 2/3] dt-bindings: phy: intel: Add Keem Bay eMMC PHY bindings Wan Ahmad Zainie
2020-09-14 17:47 ` Rob Herring
2020-09-13 23:55 ` [PATCH v9 3/3] phy: intel: Add Keem Bay eMMC PHY support Wan Ahmad Zainie
2020-09-16 12:15 ` [PATCH v9 0/3] " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200913235522.4316-1-wan.ahmad.zainie.wan.mohamad@intel.com \
--to=wan.ahmad.zainie.wan.mohamad@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=eswara.kota@linux.intel.com \
--cc=kishon@ti.com \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).