From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BCC9C43461 for ; Mon, 14 Sep 2020 20:03:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8681207EA for ; Mon, 14 Sep 2020 20:03:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600113788; bh=l4Q4WPuEytbe/ZhzYL6FNXk2+70d3f/3OC4oKlTk4zA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=hj12yVdkZVbik0rgzGx/HxIdXCUYTJ7177arKcxYt/nMjolk8y+W4IkmF1TA0YQsB gxawIR7UG2c8T/UwNZ7A1dK3a5IOC+imGOBwtIOMYOZ4KTInN7KaVAbF7UlGmk+94K 7noTlfaPirWs7yZFR0XnTwOX645/vz7kCoRsEUTY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726039AbgINUDG (ORCPT ); Mon, 14 Sep 2020 16:03:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:33376 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725994AbgINUDC (ORCPT ); Mon, 14 Sep 2020 16:03:02 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 354A5207EA; Mon, 14 Sep 2020 20:03:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600113781; bh=l4Q4WPuEytbe/ZhzYL6FNXk2+70d3f/3OC4oKlTk4zA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0JSe+BRQnuBv9MknhqUcoIWiIpdTzU2B5ghDLqRhoYOujklgzUCKnb+onVuFSSefW r2lpUr1U/uIgk6W06goftBPLsMY/Q8Xp/4ZvmCFni+w8B2Xj4mAGXixYnbRsXjzwvQ qoFgKuL6vgVD8Z8GCq7T2NMhBBp8XAPZPGkEDPbM= Date: Mon, 14 Sep 2020 13:02:59 -0700 From: Jakub Kicinski To: Tariq Toukan Cc: David Miller , luojiaxing@huawei.com, idos@mellanox.com, ogerlitz@mellanox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH net-next] net: ethernet: mlx4: Avoid assigning a value to ring_cons but not used it anymore in mlx4_en_xmit() Message-ID: <20200914130259.6b0e2ec6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <1599898095-10712-1-git-send-email-luojiaxing@huawei.com> <20200912.182219.1013721666435098048.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 13 Sep 2020 13:12:05 +0300 Tariq Toukan wrote: > 2. When MLX4_EN_PERF_STAT is not defined, we should totally remove the > local variable declaration, not only its usage. I was actually wondering about this when working on the pause stat patch. Where is MLX4_EN_PERF_STAT ever defined? $ git grep MLX4_EN_PERF_STAT drivers/net/ethernet/mellanox/mlx4/mlx4_en.h:#ifdef MLX4_EN_PERF_STAT drivers/net/ethernet/mellanox/mlx4/mlx4_en.h:#endif /* MLX4_EN_PERF_STAT */ drivers/net/ethernet/mellanox/mlx4/mlx4_stats.h:#ifdef MLX4_EN_PERF_STAT