From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45CA4C433E2 for ; Mon, 14 Sep 2020 16:00:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D983420EDD for ; Mon, 14 Sep 2020 16:00:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="jk2QemzA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726090AbgINQAO (ORCPT ); Mon, 14 Sep 2020 12:00:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726536AbgINPqe (ORCPT ); Mon, 14 Sep 2020 11:46:34 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C087C061224 for ; Mon, 14 Sep 2020 08:46:14 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id w5so156404wrp.8 for ; Mon, 14 Sep 2020 08:46:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/bIA2YmUmXjfEQqSveKUMWzIp1Qh5l6kP8KUqfJvUYc=; b=jk2QemzAep7aiq8P/HwiXdSGtnzJ++v1QrzrmmVtaYBOt+Y3E0hlOPxJcExY1QsCDp p+895PsxdfOOnMMDJLCPMo0KMJG8Jcvx89sLickgyle/2OJcZa5/4aNP02q496RmW3hb dW9Z+F1PY83kT1w1nNellUjpmzAh7syuPOM4/Ji+nSJAL6H5o0d85VrTciXtIUIqV2IE JP1y9WE10lHZhd05Ueb+eJJsCnSSgs7dF0aU3er2QR3AXoGm9OmH2yF69rUDaN+vcSxl 4+7izozlmkKqDr2K7gU4wLcMkI7/5osBI4VQBSZRDZUnzDBXQETHA/N6WFQcUAb2p09h Z3Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/bIA2YmUmXjfEQqSveKUMWzIp1Qh5l6kP8KUqfJvUYc=; b=HvYk+91U3j1MtCf1jmajigRHIqJM2cKGJw/WmmESF6mfMldXDxsT3bg/AzqBIYhkDD XG0/T6pwnRWeedYr/j0b9/ohr9e1YRguejX1NjorlwqiolWX+xPwe+796c51C12ozhT3 t+BPFLr4I7eWrfucGbeB7bm6W7Uc1zN6JiMUIJ4dFyuiUQ32lilpiiWUgUfk2ymc5oXT H9rxm8JsQ4Zjrw3G6arSNwNJGyGN370nMUMU7G7FuWBbOe+AbqWoSDEiPd7z5+vG5wCR p6P95JHSe6zzJ2sUE0OV+9LG0blMetbUkOtR918OaXcl5GB3+Cgh3B40/QyynBEoQ30s DEbw== X-Gm-Message-State: AOAM532vqkgvDn08QH4WaRpG4NNkeb7oCQva4gllws5NVUBtkb9iunIJ szcLAYCbf2X8wz/GXisHZEbNFg== X-Google-Smtp-Source: ABdhPJzNyScHgNXmICEfdwO3M4sHDrQlUGaTo060vEI/UTF5d/kYM1HJMQwFiyn2Jh+pBIsNPvPnpA== X-Received: by 2002:a5d:4104:: with SMTP id l4mr16512968wrp.396.1600098373177; Mon, 14 Sep 2020 08:46:13 -0700 (PDT) Received: from debian-brgl.home (lfbn-nic-1-68-20.w2-15.abo.wanadoo.fr. [2.15.159.20]) by smtp.gmail.com with ESMTPSA id l19sm19510448wmi.8.2020.09.14.08.46.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 08:46:12 -0700 (PDT) From: Bartosz Golaszewski To: Alessandro Zummo , Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v3 09/14] rtc: rx8010: use a helper variable for client->dev in probe() Date: Mon, 14 Sep 2020 17:45:56 +0200 Message-Id: <20200914154601.32245-10-brgl@bgdev.pl> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200914154601.32245-1-brgl@bgdev.pl> References: <20200914154601.32245-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartosz Golaszewski Simple 'dev' looks better then repeated &client->dev and has the added benefit of avoiding unnecessary line breaks. Signed-off-by: Bartosz Golaszewski --- drivers/rtc/rtc-rx8010.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-rx8010.c b/drivers/rtc/rtc-rx8010.c index 64a9964eb5e0..dba7c3f87d9e 100644 --- a/drivers/rtc/rtc-rx8010.c +++ b/drivers/rtc/rtc-rx8010.c @@ -419,6 +419,7 @@ static int rx8010_probe(struct i2c_client *client, { struct i2c_adapter *adapter = client->adapter; const struct rtc_class_ops *rtc_ops; + struct device *dev = &client->dev; struct rx8010_data *rx8010; int err = 0; @@ -428,8 +429,7 @@ static int rx8010_probe(struct i2c_client *client, return -EIO; } - rx8010 = devm_kzalloc(&client->dev, sizeof(struct rx8010_data), - GFP_KERNEL); + rx8010 = devm_kzalloc(dev, sizeof(struct rx8010_data), GFP_KERNEL); if (!rx8010) return -ENOMEM; @@ -441,13 +441,13 @@ static int rx8010_probe(struct i2c_client *client, return err; if (client->irq > 0) { - dev_info(&client->dev, "IRQ %d supplied\n", client->irq); - err = devm_request_threaded_irq(&client->dev, client->irq, NULL, + dev_info(dev, "IRQ %d supplied\n", client->irq); + err = devm_request_threaded_irq(dev, client->irq, NULL, rx8010_irq_1_handler, IRQF_TRIGGER_LOW | IRQF_ONESHOT, "rx8010", client); if (err) { - dev_err(&client->dev, "unable to request IRQ\n"); + dev_err(dev, "unable to request IRQ\n"); return err; } @@ -456,11 +456,10 @@ static int rx8010_probe(struct i2c_client *client, rtc_ops = &rx8010_rtc_ops_default; } - rx8010->rtc = devm_rtc_device_register(&client->dev, client->name, + rx8010->rtc = devm_rtc_device_register(dev, client->name, rtc_ops, THIS_MODULE); - if (IS_ERR(rx8010->rtc)) { - dev_err(&client->dev, "unable to register the class device\n"); + dev_err(dev, "unable to register the class device\n"); return PTR_ERR(rx8010->rtc); } -- 2.26.1