From: Moritz Fischer <mdf@kernel.org>
To: Xu Yilun <yilun.xu@intel.com>
Cc: mdf@kernel.org, linux-fpga@vger.kernel.org,
linux-kernel@vger.kernel.org, masahiroy@kernel.org,
trix@redhat.com, lgoncalv@redhat.com, Wu Hao <hao.wu@intel.com>,
Matthew Gerlach <matthew.gerlach@linux.intel.com>,
Russ Weight <russell.h.weight@intel.com>
Subject: Re: [PATCH v2 1/4] fpga: dfl: move dfl_device_id to mod_devicetable.h
Date: Mon, 14 Sep 2020 20:59:09 -0700 [thread overview]
Message-ID: <20200915035909.GA2217@epycbox.lan> (raw)
In-Reply-To: <1600140473-12351-2-git-send-email-yilun.xu@intel.com>
On Tue, Sep 15, 2020 at 11:27:50AM +0800, Xu Yilun wrote:
> In order to support MODULE_DEVICE_TABLE() for dfl device driver, this
> patch moves struct dfl_device_id to mod_devicetable.h
>
> Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> Signed-off-by: Wu Hao <hao.wu@intel.com>
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> Reviewed-by: Tom Rix <trix@redhat.com>
> Acked-by: Wu Hao <hao.wu@intel.com>
> ---
> v2: fix the order for the header file
> ---
> drivers/fpga/dfl.h | 13 +------------
> include/linux/mod_devicetable.h | 12 ++++++++++++
> 2 files changed, 13 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
> index 5dc758f..3c69596 100644
> --- a/drivers/fpga/dfl.h
> +++ b/drivers/fpga/dfl.h
> @@ -22,6 +22,7 @@
> #include <linux/interrupt.h>
> #include <linux/iopoll.h>
> #include <linux/io-64-nonatomic-lo-hi.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/uuid.h>
> @@ -526,18 +527,6 @@ enum dfl_id_type {
> };
>
> /**
> - * struct dfl_device_id - dfl device identifier
> - * @type: contains 4 bits DFL FIU type of the device. See enum dfl_id_type.
> - * @feature_id: contains 12 bits feature identifier local to its DFL FIU type.
> - * @driver_data: driver specific data.
> - */
> -struct dfl_device_id {
> - u8 type;
> - u16 feature_id;
> - unsigned long driver_data;
> -};
> -
> -/**
> * struct dfl_device - represent an dfl device on dfl bus
> *
> * @dev: generic device interface.
> diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
> index 5b08a47..407d8dc 100644
> --- a/include/linux/mod_devicetable.h
> +++ b/include/linux/mod_devicetable.h
> @@ -838,4 +838,16 @@ struct mhi_device_id {
> kernel_ulong_t driver_data;
> };
>
> +/**
> + * struct dfl_device_id - dfl device identifier
> + * @type: contains 4 bits DFL FIU type of the device. See enum dfl_id_type.
> + * @feature_id: contains 12 bits feature identifier local to its DFL FIU type.
> + * @driver_data: driver specific data.
> + */
> +struct dfl_device_id {
> + __u8 type;
> + __u16 feature_id;
> + kernel_ulong_t driver_data;
> +};
> +
> #endif /* LINUX_MOD_DEVICETABLE_H */
> --
> 2.7.4
>
Applied to for-next,
Thanks
next prev parent reply other threads:[~2020-09-15 3:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 3:27 [PATCH v2 0/4] add DFL bus support to MODULE_DEVICE_TABLE() Xu Yilun
2020-09-15 3:27 ` [PATCH v2 1/4] fpga: dfl: move dfl_device_id to mod_devicetable.h Xu Yilun
2020-09-15 3:59 ` Moritz Fischer [this message]
2020-09-15 3:27 ` [PATCH v2 2/4] dfl: add dfl bus support to MODULE_DEVICE_TABLE() Xu Yilun
2020-09-15 3:59 ` Moritz Fischer
[not found] ` <DM6PR11MB381970CD3C77534AA3E4C76385200@DM6PR11MB3819.namprd11.prod.outlook.com>
2020-09-15 5:19 ` Xu Yilun
[not found] ` <DM6PR11MB3819106F9D50E39F7CC7837D85200@DM6PR11MB3819.namprd11.prod.outlook.com>
2020-09-15 18:07 ` Moritz Fischer
2020-09-16 0:24 ` Xu Yilun
2020-09-15 3:27 ` [PATCH v2 3/4] fpga: dfl: fix the comments of type & feature_id fields Xu Yilun
2020-09-15 3:59 ` Moritz Fischer
2020-09-15 4:42 ` Wu, Hao
2020-09-15 3:27 ` [PATCH v2 4/4] fpga: dfl: move dfl bus related APIs to include/linux/fpga/dfl.h Xu Yilun
2020-09-15 22:55 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915035909.GA2217@epycbox.lan \
--to=mdf@kernel.org \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=russell.h.weight@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).