From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD3E8C43461 for ; Tue, 15 Sep 2020 06:39:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 716F02076C for ; Tue, 15 Sep 2020 06:39:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726062AbgIOGjl (ORCPT ); Tue, 15 Sep 2020 02:39:41 -0400 Received: from verein.lst.de ([213.95.11.211]:46615 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726033AbgIOGj1 (ORCPT ); Tue, 15 Sep 2020 02:39:27 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id A44226736F; Tue, 15 Sep 2020 08:39:23 +0200 (CEST) Date: Tue, 15 Sep 2020 08:39:23 +0200 From: Christoph Hellwig To: Harald Freudenberger Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com Subject: Re: [PATCH] s390/zcrypt: remove set_fs() invocation in zcrypt device driver Message-ID: <20200915063923.GA19468@lst.de> References: <20200910102838.28887-1-freude@linux.ibm.com> <20200911062134.GB21597@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 14, 2020 at 09:36:07AM +0200, Harald Freudenberger wrote: > Christoph, maybe you have a greater idea on how to solve this. So don't hesitate and tell me. > Otherwise how to we provide this fix then ? My recommendation would be to go the 'usual' way: > Commit this s390 internal and then let this go out with the next kernel merge window when > next time Linus is pulling patches from the s390 subsystem for the 5.10 kernel development cycle. What I did for the networking code is to add a new structure that contains a union of the kernel and userspace pointer and a flag for which one to use. That is pretty much the same as what you did, just a little more structured and type safe. The other alternative would be to use the iov_iter infrastructure, but that has some overhead.