From: Jiri Pirko <jiri@resnulli.us>
To: Ido Schimmel <idosch@idosch.org>
Cc: Moshe Shemesh <moshe@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@mellanox.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next RFC v4 04/15] devlink: Add reload actions stats to dev get
Date: Tue, 15 Sep 2020 09:44:02 +0200 [thread overview]
Message-ID: <20200915074402.GM2236@nanopsycho.orion> (raw)
In-Reply-To: <20200915064519.GA5390@shredder>
Tue, Sep 15, 2020 at 08:45:19AM CEST, idosch@idosch.org wrote:
>On Mon, Sep 14, 2020 at 03:45:00PM +0200, Jiri Pirko wrote:
>> Mon, Sep 14, 2020 at 08:07:51AM CEST, moshe@mellanox.com wrote:
>> >Expose devlink reload actions stats to the user through devlink dev
>> >get command.
>> >
>> >Examples:
>> >$ devlink dev show
>> >pci/0000:82:00.0:
>> > reload_action_stats:
>> > driver_reinit 2
>> > fw_activate 1
>> > driver_reinit_no_reset 0
>> > fw_activate_no_reset 0
>> >pci/0000:82:00.1:
>> > reload_action_stats:
>> > driver_reinit 1
>> > fw_activate 1
>> > driver_reinit_no_reset 0
>> > fw_activate_no_reset 0
>>
>> I would rather have something like:
>> stats:
>> reload_action:
>> driver_reinit 1
>> fw_activate 1
>> driver_reinit_no_reset 0
>> fw_activate_no_reset 0
>>
>> Then we can easily extend and add other stats in the tree.
>>
>>
>> Also, I wonder if these stats could be somehow merged with Ido's metrics
>> work:
>> https://github.com/idosch/linux/commits/submit/devlink_metric_rfc_v1
>>
>> Ido, would it make sense?
>
>I guess. My original idea for devlink-metric was to expose
>design-specific metrics to user space where the entity registering the
>metrics is the device driver. In this case the entity would be devlink
>itself and it would be auto-registered for each device.
Yeah, the usecase is different, but it is still stats, right.
>
>>
>>
>> >
>> >$ devlink dev show -jp
>> >{
>> > "dev": {
>> > "pci/0000:82:00.0": {
>> > "reload_action_stats": [ {
>> > "driver_reinit": 2
>> > },{
>> > "fw_activate": 1
>> > },{
>> > "driver_reinit_no_reset": 0
>> > },{
>> > "fw_activate_no_reset": 0
>> > } ]
>> > },
>> > "pci/0000:82:00.1": {
>> > "reload_action_stats": [ {
>> > "driver_reinit": 1
>> > },{
>> > "fw_activate": 1
>> > },{
>> > "driver_reinit_no_reset": 0
>> > },{
>> > "fw_activate_no_reset": 0
>> > } ]
>> > }
>> > }
>> >}
>> >
>>
>> [..]
next prev parent reply other threads:[~2020-09-15 7:45 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 6:07 [PATCH net-next RFC v4 00/15] Add devlink reload action and Moshe Shemesh
2020-09-14 6:07 ` [PATCH net-next RFC v4 01/15] devlink: Add reload action option to devlink reload command Moshe Shemesh
2020-09-14 7:08 ` Vasundhara Volam
2020-09-14 9:32 ` Jiri Pirko
2020-09-14 9:54 ` Vasundhara Volam
2020-09-14 11:28 ` Jiri Pirko
2020-09-14 21:31 ` Jakub Kicinski
2020-09-14 22:06 ` Michael Chan
2020-09-15 6:18 ` Jiri Pirko
2020-09-14 12:27 ` Jiri Pirko
2020-09-15 12:12 ` Moshe Shemesh
2020-09-15 13:26 ` Jiri Pirko
2020-09-15 20:06 ` Moshe Shemesh
2020-09-14 21:33 ` Jakub Kicinski
2020-09-15 12:56 ` Moshe Shemesh
2020-09-15 13:26 ` Jiri Pirko
2020-09-15 16:00 ` Jakub Kicinski
2020-09-14 6:07 ` [PATCH net-next RFC v4 02/15] devlink: Add reload action limit level Moshe Shemesh
2020-09-14 13:10 ` Jiri Pirko
2020-09-15 12:15 ` Moshe Shemesh
2020-09-14 6:07 ` [PATCH net-next RFC v4 03/15] devlink: Add reload action stats Moshe Shemesh
2020-09-14 13:39 ` Jiri Pirko
2020-09-15 12:30 ` Moshe Shemesh
2020-09-15 13:33 ` Jiri Pirko
2020-09-15 20:20 ` Moshe Shemesh
2020-09-16 6:07 ` Jiri Pirko
2020-09-14 6:07 ` [PATCH net-next RFC v4 04/15] devlink: Add reload actions stats to dev get Moshe Shemesh
2020-09-14 13:45 ` Jiri Pirko
2020-09-15 6:45 ` Ido Schimmel
2020-09-15 7:44 ` Jiri Pirko [this message]
2020-09-15 12:31 ` Moshe Shemesh
2020-09-15 13:34 ` Jiri Pirko
2020-09-15 20:33 ` Moshe Shemesh
2020-09-18 16:13 ` Moshe Shemesh
2020-09-21 10:33 ` Jiri Pirko
2020-09-14 6:07 ` [PATCH net-next RFC v4 05/15] net/mlx5: Add functions to set/query MFRL register Moshe Shemesh
2020-09-14 6:07 ` [PATCH net-next RFC v4 06/15] net/mlx5: Set cap for pci sync for fw update event Moshe Shemesh
2020-09-14 6:07 ` [PATCH net-next RFC v4 07/15] net/mlx5: Handle sync reset request event Moshe Shemesh
2020-09-14 6:07 ` [PATCH net-next RFC v4 08/15] net/mlx5: Handle sync reset now event Moshe Shemesh
2020-09-14 6:07 ` [PATCH net-next RFC v4 09/15] net/mlx5: Handle sync reset abort event Moshe Shemesh
2020-09-14 6:07 ` [PATCH net-next RFC v4 10/15] net/mlx5: Add support for devlink reload action fw activate Moshe Shemesh
2020-09-14 13:52 ` Jiri Pirko
2020-09-15 12:38 ` Moshe Shemesh
2020-09-14 13:54 ` Jiri Pirko
2020-09-15 12:44 ` Moshe Shemesh
2020-09-15 13:37 ` Jiri Pirko
2020-09-15 20:28 ` Moshe Shemesh
2020-09-16 6:08 ` Jiri Pirko
2020-09-14 6:07 ` [PATCH net-next RFC v4 11/15] devlink: Add enable_remote_dev_reset generic parameter Moshe Shemesh
2020-09-14 14:12 ` Jiri Pirko
2020-09-14 6:07 ` [PATCH net-next RFC v4 12/15] net/mlx5: Add devlink param enable_remote_dev_reset support Moshe Shemesh
2020-09-14 6:08 ` [PATCH net-next RFC v4 13/15] net/mlx5: Add support for fw live patch event Moshe Shemesh
2020-09-14 6:08 ` [PATCH net-next RFC v4 14/15] net/mlx5: Add support for devlink reload action limit level no reset Moshe Shemesh
2020-09-14 6:08 ` [PATCH net-next RFC v4 15/15] devlink: Add Documentation/networking/devlink/devlink-reload.rst Moshe Shemesh
2020-09-14 11:43 ` Jiri Pirko
2020-09-15 16:04 ` Jakub Kicinski
2020-09-15 19:59 ` Moshe Shemesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915074402.GM2236@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).