From: Leon Romanovsky <leon@kernel.org>
To: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Cc: dledford@redhat.com, jgg@mellanox.com,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
paul@pgazz.com, jeho@cs.utexas.edu
Subject: Re: [PATCH] IB/rxe: fix kconfig dependency warning for RDMA_RXE
Date: Tue, 15 Sep 2020 13:59:20 +0300 [thread overview]
Message-ID: <20200915105920.GA486552@unreal> (raw)
In-Reply-To: <20200915101559.33292-1-fazilyildiran@gmail.com>
On Tue, Sep 15, 2020 at 01:16:00PM +0300, Necip Fazil Yildiran wrote:
> When RDMA_RXE is enabled and CRYPTO is disabled, it results in the
> following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for CRYPTO_CRC32
> Depends on [n]: CRYPTO [=n]
> Selected by [y]:
> - RDMA_RXE [=y] && (INFINIBAND_USER_ACCESS [=y] || !INFINIBAND_USER_ACCESS [=y]) && INET [=y] && PCI [=y] && INFINIBAND [=y] && (!64BIT || ARCH_DMA_ADDR_T_64BIT [=n])
>
> The reason is that RDMA_RXE selects CRYPTO_CRC32 without depending on or
> selecting CRYPTO while CRYPTO_CRC32 is subordinate to CRYPTO.
It is not RXE specific issue and almost all users of CRYPTO_* configs
don't select CRYPTO.
There are two possible solutions.
1. Fix crypto/Kconfig to enable CRYPTO.
2. Change "select CRYPTO_CRC32" to be "depends on CRYPTO_CRC32".
Thanks
>
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
>
> Fixes: 0812ed132178 ("IB/rxe: Change RDMA_RXE kconfig to use select")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
> ---
> drivers/infiniband/sw/rxe/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/sw/rxe/Kconfig b/drivers/infiniband/sw/rxe/Kconfig
> index a0c6c7dfc181..e1f52710edfc 100644
> --- a/drivers/infiniband/sw/rxe/Kconfig
> +++ b/drivers/infiniband/sw/rxe/Kconfig
> @@ -4,6 +4,7 @@ config RDMA_RXE
> depends on INET && PCI && INFINIBAND
> depends on !64BIT || ARCH_DMA_ADDR_T_64BIT
> select NET_UDP_TUNNEL
> + select CRYPTO
> select CRYPTO_CRC32
> select DMA_VIRT_OPS
> help
> --
> 2.25.1
>
next prev parent reply other threads:[~2020-09-15 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 10:16 [PATCH] IB/rxe: fix kconfig dependency warning for RDMA_RXE Necip Fazil Yildiran
2020-09-15 10:59 ` Leon Romanovsky [this message]
2020-09-15 11:23 ` Jason Gunthorpe
2020-09-15 12:45 ` Necip F. Yıldıran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915105920.GA486552@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=fazilyildiran@gmail.com \
--cc=jeho@cs.utexas.edu \
--cc=jgg@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=paul@pgazz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).