linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Will Deacon <will@kernel.org>, John Garry <john.garry@huawei.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Suleiman Souhlal <suleiman@google.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2] perf kvm: add kvm-stat for arm64
Date: Tue, 15 Sep 2020 21:21:09 +0800	[thread overview]
Message-ID: <20200915132109.GB32758@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20200915111541.GB604@jagdpanzerIV.localdomain>

On Tue, Sep 15, 2020 at 08:15:41PM +0900, Sergey Senozhatsky wrote:
> On (20/09/15 19:57), Sergey Senozhatsky wrote:
> > On (20/09/15 18:36), Leo Yan wrote:
> > > > +#define HVC_STUB_ERR		  0xbadca11
> > > > +
> > > > +/* Per asm/kvm_asm.h */
> > > > +#define ARM_EXCEPTION_IRQ		0
> > > > +#define ARM_EXCEPTION_EL1_SERROR	1
> > > > +#define ARM_EXCEPTION_TRAP		2
> > > > +#define ARM_EXCEPTION_IL		3
> > >
> > > Nitpick: from completeness, we also can give out KVM exiting reason
> > > for 'ARM_EXCEPTION_IL'.
> >
> > OK, let me take a look.
> 
> I think ARM_EXCEPTION_IL are reported as HYP_GONE. According to
> arch/arm64/include/asm/kvm_asm.h
> 
> ---
> #define ARM_EXCEPTION_IRQ	  0
> #define ARM_EXCEPTION_EL1_SERROR  1
> #define ARM_EXCEPTION_TRAP	  2
> #define ARM_EXCEPTION_IL	  3
> 
> #define kvm_arm_exception_type					\
> 	{ARM_EXCEPTION_IRQ,		"IRQ"		},	\
> 	{ARM_EXCEPTION_EL1_SERROR, 	"SERROR"	},	\
> 	{ARM_EXCEPTION_TRAP, 		"TRAP"		},	\
> 	{ARM_EXCEPTION_HYP_GONE,	"HYP_GONE"	}
> ---
> 
> So it should be reported already.

Thanks for double checking.  But I still think this is incorrect,
ARM_EXCEPTION_HYP_GONE is defined as HVC_STUB_ERR (0xbadca11), which
is different from ARM_EXCEPTION_IL (3).  So I don't understand why you
have the conclusion that 'ARM_EXCEPTION_IL are reported as HYP_GONE'.

Sorry if I miss anything for this.

Thanks,
Leo

  reply	other threads:[~2020-09-16  0:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15  9:11 [PATCHv2] perf kvm: add kvm-stat for arm64 Sergey Senozhatsky
2020-09-15 10:36 ` Leo Yan
2020-09-15 10:57   ` Sergey Senozhatsky
2020-09-15 11:15     ` Sergey Senozhatsky
2020-09-15 13:21       ` Leo Yan [this message]
2020-09-16  0:44         ` Sergey Senozhatsky
2020-09-16  7:51           ` Leo Yan
2020-09-16  8:00             ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200915132109.GB32758@leoy-ThinkPad-X240s \
    --to=leo.yan@linaro.org \
    --cc=john.garry@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=suleiman@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).