From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Prabhakar <prabhakar.csengg@gmail.com>
Subject: Re: [PATCH] media: Kconfig: Update help description VIDEO_RENESAS_FCP config
Date: Wed, 16 Sep 2020 00:30:08 +0300 [thread overview]
Message-ID: <20200915213008.GB28219@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200915212607.GC3998@pendragon.ideasonboard.com>
On Wed, Sep 16, 2020 at 12:26:08AM +0300, Laurent Pinchart wrote:
> Hi Prabhakar,
>
> Thank you for the patch.
>
> On Fri, Sep 11, 2020 at 11:10:46AM +0100, Lad Prabhakar wrote:
> > rcar-fcp driver is also used on Renesas RZ/G2 SoC's, update the same
>
> I'm not sure what you mean by "the same" here. I'd propose
>
> The rcar_dw_hdmi driver is also used on Renesas RZ/G2 SoCs. Update the
> Kconfig entry description to reflect this.
And this was meant to be sent as a review of the DRM_RCAR_DW_HDMI patch
:-S For this patch, you could write
"The rcar-fcp driver is also used on Renesas RZ/G2 SoCs. Update the
Kconfig entry description to reflect this."
I would also replace the subject line with
"media: rcar-fcp: Update description for VIDEO_RENESAS_FCP Kconfig entry"
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> If you're fine with that, there's no need to resubmit the patch.
>
> > to reflect help description for VIDEO_RENESAS_FCP config.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > ---
> > drivers/media/platform/Kconfig | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> > index bbf32086b607..a5716e9f463a 100644
> > --- a/drivers/media/platform/Kconfig
> > +++ b/drivers/media/platform/Kconfig
> > @@ -426,8 +426,8 @@ config VIDEO_RENESAS_FCP
> > help
> > This is a driver for the Renesas Frame Compression Processor (FCP).
> > The FCP is a companion module of video processing modules in the
> > - Renesas R-Car Gen3 SoCs. It handles memory access for the codec,
> > - VSP and FDP modules.
> > + Renesas R-Car Gen3 and RZ/G2 SoCs. It handles memory access for
> > + the codec, VSP and FDP modules.
> >
> > To compile this driver as a module, choose M here: the module
> > will be called rcar-fcp.
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2020-09-15 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 10:10 [PATCH] media: Kconfig: Update help description VIDEO_RENESAS_FCP config Lad Prabhakar
2020-09-11 11:33 ` Sergei Shtylyov
2020-09-15 21:26 ` Laurent Pinchart
2020-09-15 21:30 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915213008.GB28219@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert+renesas@glider.be \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).