From: Leon Romanovsky <leon@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Maor Gottlieb <maorg@nvidia.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next v1 2/4] lib/scatterlist: Add support in dynamically allocation of SG entries
Date: Wed, 16 Sep 2020 10:18:24 +0300 [thread overview]
Message-ID: <20200916071824.GD486552@unreal> (raw)
In-Reply-To: <20200915161926.GB24320@lst.de>
On Tue, Sep 15, 2020 at 06:19:26PM +0200, Christoph Hellwig wrote:
> > + /* We decrease one since the prvious last sge in used to
> > + * chainning.
> > + */
>
> The normal style would be:
It is netdev style of formatting, will change.
>
> /*
> * We decrease one since the prvious last sge in used to
> * chain the chunks together.
> */
>
> (also fixing up what I think it should be saying while I'm at it)
>
> > + * Thus if @nents is bigger than @max_ents, the scatterlists will be
> > + * chained in units of @max_ents.
> > + *
> > + **/
> > +static int sg_alloc_next(struct sg_table *table, struct scatterlist *last,
> > + unsigned int nents, unsigned int max_ents,
> > + gfp_t gfp_mask)
> > +{
> > + return sg_alloc(table, last, nents, max_ents, NULL, 0, gfp_mask,
> > + sg_kmalloc);
> > +}
>
> This helper seems unused in this patch. For bisection you probably
> want to move it into the next patch with the user.
>
> In fact I'm not even sure there is much of a point in splitting out
> this patch either.
We will squash.
next prev parent reply other threads:[~2020-09-16 7:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 13:42 [PATCH rdma-next v1 0/4] scatterlist: add sg_alloc_table_append function Leon Romanovsky
2020-09-10 13:42 ` [PATCH rdma-next v1 1/4] lib/scatterlist: Refactor sg_alloc_table_from_pages Leon Romanovsky
2020-09-15 16:16 ` Christoph Hellwig
2020-09-16 7:17 ` Leon Romanovsky
2020-09-10 13:42 ` [PATCH rdma-next v1 2/4] lib/scatterlist: Add support in dynamically allocation of SG entries Leon Romanovsky
2020-09-15 16:19 ` Christoph Hellwig
2020-09-16 7:18 ` Leon Romanovsky [this message]
2020-09-10 13:42 ` [PATCH rdma-next v1 3/4] lib/scatterlist: Add support in dynamic allocation of SG table from pages Leon Romanovsky
2020-09-15 16:23 ` Christoph Hellwig
2020-09-16 7:19 ` Leon Romanovsky
2020-09-10 13:42 ` [PATCH rdma-next v1 4/4] RDMA/umem: Move to allocate " Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916071824.GD486552@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).