archive mirror
 help / color / mirror / Atom feed
From: Mike Rapoport <>
To: Andrew Morton <>
Cc: Alexander Viro <>,
	Andy Lutomirski <>, Arnd Bergmann <>,
	Borislav Petkov <>,
	Catalin Marinas <>,
	Christopher Lameter <>,
	Dan Williams <>,
	Dave Hansen <>,
	David Hildenbrand <>,
	Elena Reshetova <>,
	"H. Peter Anvin" <>, Idan Yaniv <>,
	Ingo Molnar <>,
	James Bottomley <>,
	"Kirill A. Shutemov" <>,
	Matthew Wilcox <>,
	Mark Rutland <>,
	Mike Rapoport <>,
	Mike Rapoport <>,
	Michael Kerrisk <>,
	Palmer Dabbelt <>,
	Paul Walmsley <>,
	Peter Zijlstra <>,
	Thomas Gleixner <>,
	Tycho Andersen <>, Will Deacon <>,,,,,,,,,
Subject: [PATCH v5 0/5] mm: introduce memfd_secret system call to create "secret" memory areas
Date: Wed, 16 Sep 2020 10:35:34 +0300	[thread overview]
Message-ID: <> (raw)

From: Mike Rapoport <>


This is an implementation of "secret" mappings backed by a file descriptor. 
I've dropped the boot time reservation patch for now as it is not strictly
required for the basic usage and can be easily added later either with or
without CMA.

v5 changes:
* rebase on v5.9-rc5
* drop boot time memory reservation patch

v4 changes:
* rebase on v5.9-rc1
* Do not redefine PMD_PAGE_ORDER in fs/dax.c, thanks Kirill
* Make secret mappings exclusive by default and only require flags to
  memfd_secret() system call for uncached mappings, thanks again Kirill :)

v3 changes:
* Squash kernel-parameters.txt update into the commit that added the
  command line option.
* Make uncached mode explicitly selectable by architectures. For now enable
  it only on x86.

v2 changes:
* Follow Michael's suggestion and name the new system call 'memfd_secret'
* Add kernel-parameters documentation about the boot option
* Fix i386-tinyconfig regression reported by the kbuild bot.
  CONFIG_SECRETMEM now depends on !EMBEDDED to disable it on small systems
  from one side and still make it available unconditionally on
  architectures that support SET_DIRECT_MAP.

The file descriptor backing secret memory mappings is created using a
dedicated memfd_secret system call The desired protection mode for the
memory is configured using flags parameter of the system call. The mmap()
of the file descriptor created with memfd_secret() will create a "secret"
memory mapping. The pages in that mapping will be marked as not present in
the direct map and will have desired protection bits set in the user page
table. For instance, current implementation allows uncached mappings.

Although normally Linux userspace mappings are protected from other users, 
such secret mappings are useful for environments where a hostile tenant is
trying to trick the kernel into giving them access to other tenants

Additionally, the secret mappings may be used as a mean to protect guest
memory in a virtual machine host.

For demonstration of secret memory usage we've created a userspace library
[1] that does two things: the first is act as a preloader for openssl to
redirect all the OPENSSL_malloc calls to secret memory meaning any secret
keys get automatically protected this way and the other thing it does is
expose the API to the user who needs it. We anticipate that a lot of the
use cases would be like the openssl one: many toolkits that deal with
secret keys already have special handling for the memory to try to give
them greater protection, so this would simply be pluggable into the
toolkits without any need for user application modification.

I've hesitated whether to continue to use new flags to memfd_create() or to
add a new system call and I've decided to use a new system call after I've
started to look into man pages update. There would have been two completely
independent descriptions and I think it would have been very confusing.

Hiding secret memory mappings behind an anonymous file allows (ab)use of
the page cache for tracking pages allocated for the "secret" mappings as
well as using address_space_operations for e.g. page migration callbacks.

The anonymous file may be also used implicitly, like hugetlb files, to
implement mmap(MAP_SECRET) and use the secret memory areas with "native" mm
ABIs in the future.

As the fragmentation of the direct map was one of the major concerns raised
during the previous postings, I've added an amortizing cache of PMD-size
pages to each file descriptor that is used as an allocation pool for the
secret memory areas.


Mike Rapoport (5):
  mm: add definition of PMD_PAGE_ORDER
  mmap: make mlock_future_check() global
  mm: introduce memfd_secret system call to create "secret" memory areas
  arch, mm: wire up memfd_secret system call were relevant
  mm: secretmem: use PMD-size pages to amortize direct map fragmentation

 arch/Kconfig                           |   7 +
 arch/arm64/include/asm/unistd.h        |   2 +-
 arch/arm64/include/asm/unistd32.h      |   2 +
 arch/arm64/include/uapi/asm/unistd.h   |   1 +
 arch/riscv/include/asm/unistd.h        |   1 +
 arch/x86/Kconfig                       |   1 +
 arch/x86/entry/syscalls/syscall_32.tbl |   1 +
 arch/x86/entry/syscalls/syscall_64.tbl |   1 +
 fs/dax.c                               |  11 +-
 include/linux/pgtable.h                |   3 +
 include/linux/syscalls.h               |   1 +
 include/uapi/asm-generic/unistd.h      |   7 +-
 include/uapi/linux/magic.h             |   1 +
 include/uapi/linux/secretmem.h         |   8 +
 kernel/sys_ni.c                        |   2 +
 mm/Kconfig                             |   4 +
 mm/Makefile                            |   1 +
 mm/internal.h                          |   3 +
 mm/mmap.c                              |   5 +-
 mm/secretmem.c                         | 333 +++++++++++++++++++++++++
 20 files changed, 383 insertions(+), 12 deletions(-)
 create mode 100644 include/uapi/linux/secretmem.h
 create mode 100644 mm/secretmem.c


             reply	other threads:[~2020-09-16  7:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16  7:35 Mike Rapoport [this message]
2020-09-16  7:35 ` [PATCH v5 1/5] mm: add definition of PMD_PAGE_ORDER Mike Rapoport
2020-09-16  7:35 ` [PATCH v5 2/5] mmap: make mlock_future_check() global Mike Rapoport
2020-09-16  7:35 ` [PATCH v5 3/5] mm: introduce memfd_secret system call to create "secret" memory areas Mike Rapoport
2020-09-16 15:59   ` Randy Dunlap
2020-09-16  7:35 ` [PATCH v5 4/5] arch, mm: wire up memfd_secret system call were relevant Mike Rapoport
2020-09-16  7:35 ` [PATCH v5 5/5] mm: secretmem: use PMD-size pages to amortize direct map fragmentation Mike Rapoport
2020-09-16 23:20 ` [PATCH v5 0/5] mm: introduce memfd_secret system call to create "secret" memory areas Andrew Morton
2020-09-17  5:46   ` Michael Kerrisk (man-pages)
2020-09-17  6:02     ` Mike Rapoport
2020-09-17  6:00   ` Mike Rapoport
2020-09-17 13:27 ` Qian Cai
2020-09-18 18:25   ` Qian Cai
2020-09-21  8:07     ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2020-09-16  7:28 Mike Rapoport
2020-09-16 18:49 ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).