From: Daniel Vetter <daniel@ffwll.ch>
To: christian.koenig@amd.com
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Alex Deucher" <alexdeucher@gmail.com>,
yi.zhang@huawei.com, "Dave Airlie" <airlied@linux.ie>,
LKML <linux-kernel@vger.kernel.org>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Zheng Bin" <zhengbin13@huawei.com>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Deucher, Alexander" <alexander.deucher@amd.com>
Subject: Re: [PATCH -next 0/8] drm/amd/amdgpu: fix comparison pointer to bool warning
Date: Wed, 16 Sep 2020 09:51:56 +0200 [thread overview]
Message-ID: <20200916075156.GU438822@phenom.ffwll.local> (raw)
In-Reply-To: <6658f89f-6957-e6ea-af41-7625f1fd3cb1@gmail.com>
On Wed, Sep 16, 2020 at 09:38:34AM +0200, Christian König wrote:
> Am 15.09.20 um 21:35 schrieb Ville Syrjälä:
> > On Tue, Sep 15, 2020 at 03:16:32PM -0400, Alex Deucher wrote:
> > > I question the value of these warnings. Why even have a boolean type
> > > if you are going to get warnings when you use them...
> > > That said, applied to avoid getting these patches again and again
> > > every time someone sees this.
> > if (this_is_sparta)
> > if (this_is_sparta == true)
> > if (this_is_sparta != false)
> >
> > I think the first one reads the best, and avoids having to
> > decide between truth and falsehood :)
>
> +1
+1, especially because we also have the inversion when using negative
errno codes for failures and 0 as success, which results in
if (errno == 0) /* success case */
but
if (bool == 0) /* failure case */
now creative people do sometimes
if (!errno) /* success case */
which I think is horribly confusing. So imo for more easier telling apart
of these too I think consistently using the short form for booleans, and
consistently using the more explicit long form for errno checks is a Very
Good Pattern :-)
Cheers, Daniel
>
> Christian.
>
> >
> > > Alex
> > >
> > > On Wed, Sep 9, 2020 at 9:21 AM Christian König <christian.koenig@amd.com> wrote:
> > > > Acked-by: Christian König <christian.koenig@amd.com> for the series.
> > > >
> > > > Am 09.09.20 um 15:07 schrieb Zheng Bin:
> > > > > Zheng Bin (8):
> > > > > drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v9_0.c
> > > > > drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v10_0.c
> > > > > drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v5_0.c
> > > > > drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v5_2.c
> > > > > drm/amd/amdgpu: fix comparison pointer to bool warning in si.c
> > > > > drm/amd/amdgpu: fix comparison pointer to bool warning in uvd_v6_0.c
> > > > > drm/amd/amdgpu: fix comparison pointer to bool warning in
> > > > > amdgpu_atpx_handler.c
> > > > > drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v4_0.c
> > > > >
> > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 4 ++--
> > > > > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +-
> > > > > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-
> > > > > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 ++--
> > > > > drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 2 +-
> > > > > drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 2 +-
> > > > > drivers/gpu/drm/amd/amdgpu/si.c | 2 +-
> > > > > drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 4 ++--
> > > > > 8 files changed, 11 insertions(+), 11 deletions(-)
> > > > >
> > > > > --
> > > > > 2.26.0.106.g9fadedd
> > > > >
> > > > _______________________________________________
> > > > amd-gfx mailing list
> > > > amd-gfx@lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> > > _______________________________________________
> > > dri-devel mailing list
> > > dri-devel@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2020-09-16 7:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 13:07 [PATCH -next 0/8] drm/amd/amdgpu: fix comparison pointer to bool warning Zheng Bin
2020-09-09 13:07 ` [PATCH -next 1/8] drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v9_0.c Zheng Bin
2020-09-09 13:07 ` [PATCH -next 2/8] drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v10_0.c Zheng Bin
2020-09-09 13:07 ` [PATCH -next 3/8] drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v5_0.c Zheng Bin
2020-09-09 13:07 ` [PATCH -next 4/8] drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v5_2.c Zheng Bin
2020-09-09 13:07 ` [PATCH -next 5/8] drm/amd/amdgpu: fix comparison pointer to bool warning in si.c Zheng Bin
2020-09-09 13:07 ` [PATCH -next 6/8] drm/amd/amdgpu: fix comparison pointer to bool warning in uvd_v6_0.c Zheng Bin
2020-09-09 13:07 ` [PATCH -next 7/8] drm/amd/amdgpu: fix comparison pointer to bool warning in amdgpu_atpx_handler.c Zheng Bin
2020-09-09 13:07 ` [PATCH -next 8/8] drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v4_0.c Zheng Bin
2020-09-09 13:21 ` [PATCH -next 0/8] drm/amd/amdgpu: fix comparison pointer to bool warning Christian König
2020-09-15 19:16 ` Alex Deucher
2020-09-15 19:35 ` Ville Syrjälä
2020-09-16 7:38 ` Christian König
2020-09-16 7:51 ` Daniel Vetter [this message]
2020-09-16 13:36 ` Alex Deucher
2020-09-16 14:02 ` Christian König
2020-09-16 15:31 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916075156.GU438822@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
--cc=yi.zhang@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).