From: Jan Kara <jack@suse.cz>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Jan Kara <jack@suse.com>,
reiserfs-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+187510916eb6a14598f7@syzkaller.appspotmail.com
Subject: Re: [PATCH] reiserfs: only call unlock_new_inode() if I_NEW
Date: Wed, 16 Sep 2020 12:54:18 +0200 [thread overview]
Message-ID: <20200916105418.GC3607@quack2.suse.cz> (raw)
In-Reply-To: <20200916040118.GB825@sol.localdomain>
On Tue 15-09-20 21:01:18, Eric Biggers wrote:
> On Mon, Jul 27, 2020 at 09:52:15AM -0700, Eric Biggers wrote:
> > On Sun, Jun 28, 2020 at 12:00:57AM -0700, Eric Biggers wrote:
> > > From: Eric Biggers <ebiggers@google.com>
> > >
> > > unlock_new_inode() is only meant to be called after a new inode has
> > > already been inserted into the hash table. But reiserfs_new_inode() can
> > > call it even before it has inserted the inode, triggering the WARNING in
> > > unlock_new_inode(). Fix this by only calling unlock_new_inode() if the
> > > inode has the I_NEW flag set, indicating that it's in the table.
> > >
> > > This addresses the syzbot report "WARNING in unlock_new_inode"
> > > (https://syzkaller.appspot.com/bug?extid=187510916eb6a14598f7).
> > >
> > > Reported-by: syzbot+187510916eb6a14598f7@syzkaller.appspotmail.com
> > > Signed-off-by: Eric Biggers <ebiggers@google.com>
> >
> > Anyone interested in taking this patch?
>
> Jan, you seem to be taking some reiserfs patches... Any interest in
> taking this one?
Sure, the patch looks good to me so I've added it to my tree. Thanks!
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2020-09-16 18:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-28 7:00 [PATCH] reiserfs: only call unlock_new_inode() if I_NEW Eric Biggers
2020-07-27 16:52 ` Eric Biggers
2020-09-16 4:01 ` Eric Biggers
2020-09-16 10:54 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916105418.GC3607@quack2.suse.cz \
--to=jack@suse.cz \
--cc=ebiggers@kernel.org \
--cc=jack@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
--cc=syzbot+187510916eb6a14598f7@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).