From: Ira Weiny <ira.weiny@intel.com>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: mporter@kernel.crashing.org, alex.bou9@gmail.com,
akpm@linux-foundation.org, gustavoars@kernel.org,
jhubbard@nvidia.com, madhuparnabhowmik10@gmail.com,
dan.carpenter@oracle.com, linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [linux-next PATCH] rapidio: Fix error handling path
Date: Wed, 16 Sep 2020 08:20:04 -0700 [thread overview]
Message-ID: <20200916152004.GC2485491@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <1600227737-20785-1-git-send-email-jrdr.linux@gmail.com>
On Wed, Sep 16, 2020 at 09:12:17AM +0530, Souptick Joarder wrote:
> There is an error when pin_user_pages_fast() returns -ERRNO and
> inside error handling path driver end up calling unpin_user_pages()
> with -ERRNO which is not correct.
>
> This patch will fix the problem.
>
> Fixes: e8de370188d09 ("rapidio: add mport char device driver")
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> Cc: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> Cc: John Hubbard <jhubbard@nvidia.com>
> Cc: Matthew Wilcox <willy@infradead.org>
> ---
> drivers/rapidio/devices/rio_mport_cdev.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
> index a303429..163b6c72 100644
> --- a/drivers/rapidio/devices/rio_mport_cdev.c
> +++ b/drivers/rapidio/devices/rio_mport_cdev.c
> @@ -871,15 +871,16 @@ static int do_dma_request(struct mport_dma_req *req,
> rmcd_error("pin_user_pages_fast err=%ld",
> pinned);
> nr_pages = 0;
> - } else
> + } else {
> rmcd_error("pinned %ld out of %ld pages",
> pinned, nr_pages);
> + /*
> + * Set nr_pages up to mean "how many pages to unpin, in
> + * the error handler:
> + */
> + nr_pages = pinned;
> + }
> ret = -EFAULT;
> - /*
> - * Set nr_pages up to mean "how many pages to unpin, in
> - * the error handler:
> - */
> - nr_pages = pinned;
> goto err_pg;
> }
>
> --
> 1.9.1
>
prev parent reply other threads:[~2020-09-16 20:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 3:42 [linux-next PATCH] rapidio: Fix error handling path Souptick Joarder
2020-09-16 6:37 ` John Hubbard
2020-09-16 10:02 ` Dan Carpenter
2020-09-16 10:07 ` Dan Carpenter
2020-09-16 15:16 ` Ira Weiny
2020-09-16 15:27 ` Dan Carpenter
2020-09-17 6:57 ` [PATCH] mm/gup: protect unpin_user_pages() against npages==-ERRNO John Hubbard
2020-09-17 7:40 ` Dan Carpenter
2020-09-20 3:03 ` Souptick Joarder
2020-09-20 4:13 ` John Hubbard
2020-09-21 9:34 ` Dan Carpenter
2020-09-17 12:39 ` [linux-next PATCH] rapidio: Fix error handling path Dan Carpenter
2020-09-17 17:34 ` Ira Weiny
2020-09-17 17:47 ` John Hubbard
2020-09-18 2:21 ` Souptick Joarder
2020-09-18 6:33 ` John Hubbard
2020-09-18 2:25 ` Souptick Joarder
2020-09-18 6:15 ` Dan Carpenter
2020-09-16 15:20 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916152004.GC2485491@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alex.bou9@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gustavoars@kernel.org \
--cc=jhubbard@nvidia.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=madhuparnabhowmik10@gmail.com \
--cc=mporter@kernel.crashing.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).