linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Martin <Dave.Martin@arm.com>
To: Boyan Karatotev <boian4o1@gmail.com>
Cc: Boyan Karatotev <boyan.karatotev@arm.com>,
	Will Deacon <will@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	amit.kachhap@arm.com, vincenzo.frascino@arm.com,
	Shuah Khan <shuah@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] kselftests/arm64: add PAuth test for whether exec() changes keys
Date: Wed, 16 Sep 2020 16:38:12 +0100	[thread overview]
Message-ID: <20200916153809.GZ6642@arm.com> (raw)
In-Reply-To: <4f38a974-d5a0-87e6-3db3-647e3cc32c0e@gmail.com>

On Tue, Sep 15, 2020 at 04:18:28PM +0100, Boyan Karatotev wrote:
> On 07/09/2020 11:27 am, Dave Martin wrote:
> > On Thu, Sep 03, 2020 at 11:20:25AM +0100, Boyan Karatotev wrote:
> >> On 02/09/2020 18:00, Dave Martin wrote:
> >>> On Fri, Aug 28, 2020 at 02:16:05PM +0100, Boyan Karatotev wrote:
> >>>> +int exec_sign_all(struct signatures *signed_vals, size_t val)
> >>>> +{
> >>>
> >>> Could popen(3) be used here?
> >>>
> >>> Fork-and-exec is notoriously fiddly, so it's preferable to use a library
> >>> function to do it where applicable.I would love to, but the worker needs a bidirectional channel and popen
> >> only gives a unidirectional stream.
> > 
> > Ah, fair point.
> > 
> > Would it help if you created an additional pipe before calling popen()?
> > 
> > May not be worth it, though.  For one thing, wiring that extra pipe to
> > stdin or stdout in the child process would require some extra work...
> Well, I probably could, but I doubt the result would be any better. I
> agree that I'm not sure the effort is worth it and would rather keep it
> the same.

Sure, fair enough.

Ideally kselftest would provide some common code for this sort of thing,
but I guess that's a separate discussion.

Cheers
---Dave

  reply	other threads:[~2020-09-16 18:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-28 13:16 [PATCH 0/4] kselftests/arm64: add PAuth tests Boyan Karatotev
2020-08-28 13:16 ` [PATCH 1/4] kselftests/arm64: add a basic Pointer Authentication test Boyan Karatotev
2020-08-28 14:28   ` Vincenzo Frascino
2020-08-31  8:05   ` Amit Kachhap
2020-09-02 16:49   ` Dave Martin
2020-09-03 10:12     ` Boyan Karatotev
2020-09-07 10:23       ` Dave Martin
2020-08-28 13:16 ` [PATCH 2/4] kselftests/arm64: add nop checks for PAuth tests Boyan Karatotev
2020-08-28 14:30   ` Vincenzo Frascino
2020-08-31  8:09   ` Amit Kachhap
2020-08-28 13:16 ` [PATCH 3/4] kselftests/arm64: add PAuth test for whether exec() changes keys Boyan Karatotev
2020-08-28 14:33   ` Vincenzo Frascino
2020-08-31  8:13   ` Amit Kachhap
2020-09-02 17:00   ` Dave Martin
2020-09-03 10:20     ` Boyan Karatotev
2020-09-07 10:27       ` Dave Martin
2020-09-15 15:18         ` Boyan Karatotev
2020-09-16 15:38           ` Dave Martin [this message]
2020-08-28 13:16 ` [PATCH 4/4] kselftests/arm64: add PAuth tests for single threaded consistency and key uniqueness Boyan Karatotev
2020-08-28 14:36   ` Vincenzo Frascino
2020-08-31  8:20   ` Amit Kachhap
2020-09-02 16:48 ` [PATCH 0/4] kselftests/arm64: add PAuth tests Dave Martin
2020-09-03  9:46   ` Boyan Karatotev
2020-09-07 10:29     ` Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200916153809.GZ6642@arm.com \
    --to=dave.martin@arm.com \
    --cc=amit.kachhap@arm.com \
    --cc=boian4o1@gmail.com \
    --cc=boyan.karatotev@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=vincenzo.frascino@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).