From: Andrew Lunn <andrew@lunn.ch>
To: Dan Murphy <dmurphy@ti.com>
Cc: davem@davemloft.net, f.fainelli@gmail.com, hkallweit1@gmail.com,
mkubecek@suse.cz, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] net: dp83869: Add ability to advertise Fiber connection
Date: Thu, 17 Sep 2020 00:13:13 +0200 [thread overview]
Message-ID: <20200916221313.GI3526428@lunn.ch> (raw)
In-Reply-To: <4b297d8a-b4da-0e19-a5fb-6dda89ca4148@ti.com>
On Wed, Sep 16, 2020 at 03:54:34PM -0500, Dan Murphy wrote:
> Andrew
>
> On 9/15/20 3:17 PM, Andrew Lunn wrote:
> > > + linkmode_set_bit(ETHTOOL_LINK_MODE_100baseFX_Full_BIT,
> > > + phydev->supported);
> > > + linkmode_set_bit(ETHTOOL_LINK_MODE_100baseFX_Half_BIT,
> > > + phydev->supported);
> > > +
> > > + /* Auto neg is not supported in 100base FX mode */
> > Hi Dan
> >
> > If it does not support auto neg, how do you decide to do half duplex?
> > I don't see any code here which allows the user to configure it.
>
> Ethtool has the provisions to set the duplex and speed right?.
What i'm getting at is you say you support
ETHTOOL_LINK_MODE_100baseFX_Full_BIT &
ETHTOOL_LINK_MODE_100baseFX_Half_BIT. If there is no auto neg in FX
mode, i'm questioning how these two different modes code be used? I'm
guessing the PHY defaults to ETHTOOL_LINK_MODE_100baseFX_Full_BIT? How
does the user set it to ETHTOOL_LINK_MODE_100baseFX_Half_BIT?
> The only call back I see which is valid is config_aneg which would still
> require a user space tool to set the needed link modes.
Correct. Maybe all you need to do is point me at the code in the
driver which actually sets the PHY into half duplex in FX mode when
the user asks for it. Is it just clearing BMCR_FULLDPLX?
Andrew
next prev parent reply other threads:[~2020-09-16 22:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 18:17 [PATCH net-next 0/3] 100base Fx link modes Dan Murphy
2020-09-15 18:17 ` [PATCH net-next 1/3] ethtool: Add 100base-FX link mode entries Dan Murphy
2020-09-15 20:10 ` Andrew Lunn
2020-09-15 23:26 ` Dan Murphy
2020-09-15 20:21 ` Andrew Lunn
2020-09-15 23:29 ` Dan Murphy
2020-09-17 15:03 ` Dan Murphy
2020-09-15 18:17 ` [PATCH net-next 2/3] net: dp83869: Add ability to advertise Fiber connection Dan Murphy
2020-09-15 20:17 ` Andrew Lunn
2020-09-16 20:54 ` Dan Murphy
2020-09-16 22:13 ` Andrew Lunn [this message]
2020-09-17 14:57 ` Dan Murphy
2020-09-15 18:17 ` [PATCH net-next 3/3] net: phy: dp83822: Update the fiber advertisement for speed Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916221313.GI3526428@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).