linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] genetlink: Remove unused function genl_err_attr()
@ 2020-09-16 14:17 YueHaibing
  2020-09-17 18:34 ` Cong Wang
  2020-09-17 23:28 ` David Miller
  0 siblings, 2 replies; 4+ messages in thread
From: YueHaibing @ 2020-09-16 14:17 UTC (permalink / raw)
  To: davem, kuba, jiri; +Cc: netdev, linux-kernel, YueHaibing

It is never used, so can remove it.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 include/net/genetlink.h | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/include/net/genetlink.h b/include/net/genetlink.h
index 6e5f1e1aa822..b9eb92f3fe86 100644
--- a/include/net/genetlink.h
+++ b/include/net/genetlink.h
@@ -101,14 +101,6 @@ static inline void genl_info_net_set(struct genl_info *info, struct net *net)
 
 #define GENL_SET_ERR_MSG(info, msg) NL_SET_ERR_MSG((info)->extack, msg)
 
-static inline int genl_err_attr(struct genl_info *info, int err,
-				const struct nlattr *attr)
-{
-	info->extack->bad_attr = attr;
-
-	return err;
-}
-
 enum genl_validate_flags {
 	GENL_DONT_VALIDATE_STRICT		= BIT(0),
 	GENL_DONT_VALIDATE_DUMP			= BIT(1),
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] genetlink: Remove unused function genl_err_attr()
  2020-09-16 14:17 [PATCH net-next] genetlink: Remove unused function genl_err_attr() YueHaibing
@ 2020-09-17 18:34 ` Cong Wang
  2020-09-18  1:22   ` Yuehaibing
  2020-09-17 23:28 ` David Miller
  1 sibling, 1 reply; 4+ messages in thread
From: Cong Wang @ 2020-09-17 18:34 UTC (permalink / raw)
  To: YueHaibing
  Cc: David Miller, Jakub Kicinski, Jiri Pirko,
	Linux Kernel Network Developers, LKML

On Wed, Sep 16, 2020 at 9:33 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> It is never used, so can remove it.

This is a bit confusing, it was actually used before, see commit
ab0d76f6823cc3a4e2.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] genetlink: Remove unused function genl_err_attr()
  2020-09-16 14:17 [PATCH net-next] genetlink: Remove unused function genl_err_attr() YueHaibing
  2020-09-17 18:34 ` Cong Wang
@ 2020-09-17 23:28 ` David Miller
  1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2020-09-17 23:28 UTC (permalink / raw)
  To: yuehaibing; +Cc: kuba, jiri, netdev, linux-kernel

From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 16 Sep 2020 22:17:28 +0800

> It is never used, so can remove it.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] genetlink: Remove unused function genl_err_attr()
  2020-09-17 18:34 ` Cong Wang
@ 2020-09-18  1:22   ` Yuehaibing
  0 siblings, 0 replies; 4+ messages in thread
From: Yuehaibing @ 2020-09-18  1:22 UTC (permalink / raw)
  To: Cong Wang
  Cc: David Miller, Jakub Kicinski, Jiri Pirko,
	Linux Kernel Network Developers, LKML

On 2020/9/18 2:34, Cong Wang wrote:
> On Wed, Sep 16, 2020 at 9:33 AM YueHaibing <yuehaibing@huawei.com> wrote:
>>
>> It is never used, so can remove it.
> 
> This is a bit confusing, it was actually used before, see commit
> ab0d76f6823cc3a4e2.

Yes,thanks for reminding, will be careful later.
> .
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-09-18  1:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 14:17 [PATCH net-next] genetlink: Remove unused function genl_err_attr() YueHaibing
2020-09-17 18:34 ` Cong Wang
2020-09-18  1:22   ` Yuehaibing
2020-09-17 23:28 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).