From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C4AAC43461 for ; Thu, 17 Sep 2020 02:31:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4030F20715 for ; Thu, 17 Sep 2020 02:31:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IiaQMhPS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726101AbgIQCbY (ORCPT ); Wed, 16 Sep 2020 22:31:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726040AbgIQCbU (ORCPT ); Wed, 16 Sep 2020 22:31:20 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92762C061351 for ; Wed, 16 Sep 2020 19:31:19 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id j34so462413pgi.7 for ; Wed, 16 Sep 2020 19:31:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=2u7wbhcgfeP+OhvwSg+SAWVQGFl0XrxeVCAdE2eggas=; b=IiaQMhPSuXqLZqN62H2EziGzPykC+lkhYyaHuAc6XQxtxDXvYeQdiWhDHbMGc0X/pa XDHOUURST+EFWhRahOCLZWYAZH0tQJsHeNfJMrqhTs5gTDnmyU4Ij4ku/73zokN7Ucz1 +Sn4DHgJecpt1/gNlzQSdU91oUX8iIUQ+ncmdoNseljzRBFpxrVj6xm9Lx4Yi4R4amYZ V8XogJlaFcuB4TJLhTj88og22izyPRj8Nx4dL6gG0hEcAqLHUThB9xbKp5wCqGDQpVgK qkCeORvl14LPhkQ+R+xtAIp+gl7yeuQrpg9eYMQd1HfDaWbTnKkD/IzXWaJamenAkNMu XusQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=2u7wbhcgfeP+OhvwSg+SAWVQGFl0XrxeVCAdE2eggas=; b=fz/73gXjGqw0Y0pDKgGLvCgg3eIG1h1Z4W2FwtRnuM0AXCZ5dIMNeBw2lNV708p871 ZeJ9tYs0ijRIZpYeHYlY3wwG99K11vcGSfHOVxoA8I9KDHF2WqhK+pP8bVCBpdwJLsyH pbwqWlYFXLfWlHgQ1rasoQDnE4E49FlVmVQxWntCsoLdwo0pM+lYdNfsDKE7noNgL9G0 jOufWh1TzunCAJtqzObEJMUQpJpWK0OKvQ9PvaXAR17SDs+KazEIRkSOes82jwmI7sx5 g/ViZ7F7lNJf+lk2GfLItjJ1nDPNAlIbFsteb4SwbVOt0QqHidb8RI0d9NxkxKMN3DdX QoFg== X-Gm-Message-State: AOAM532l/5dEqbAthE/nEXq6nZixuu3HeTDqPqUPsGFWwrSh5f2QccHN 5mJFeV+HpfLdgd9wH+u+JzFCJg== X-Google-Smtp-Source: ABdhPJzBSW6XWGnayRmbLzx2RWdCT0/3tud8f6BldLbaq247IoUN57V7YiogyF53ZmZ0egVNaBH+zA== X-Received: by 2002:a63:694a:: with SMTP id e71mr20774824pgc.280.1600309878901; Wed, 16 Sep 2020 19:31:18 -0700 (PDT) Received: from laputa (p784a66b9.tkyea130.ap.so-net.ne.jp. [120.74.102.185]) by smtp.gmail.com with ESMTPSA id c6sm1288647pfd.83.2020.09.16.19.31.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 19:31:18 -0700 (PDT) Date: Thu, 17 Sep 2020 11:31:13 +0900 From: AKASHI Takahiro To: Adrian Hunter Cc: Ben Chuang , ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, ben.chuang@genesyslogic.com.tw, greg.tu@genesyslogic.com.tw Subject: Re: [RFC PATCH V3 12/21] mmc: sdhci: UHS-II support, add hooks for additional operations Message-ID: <20200917023113.GB3071249@laputa> Mail-Followup-To: AKASHI Takahiro , Adrian Hunter , Ben Chuang , ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, ben.chuang@genesyslogic.com.tw, greg.tu@genesyslogic.com.tw References: <20200710111054.29562-1-benchuanggli@gmail.com> <9fa17d60-a540-d0d8-7b2c-0016c3b5c532@intel.com> <20200916080558.GA2978867@laputa> <6bf86b26-391a-0699-1818-d070357b9ddc@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6bf86b26-391a-0699-1818-d070357b9ddc@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adrian, On Wed, Sep 16, 2020 at 01:00:35PM +0300, Adrian Hunter wrote: > On 16/09/20 11:05 am, AKASHI Takahiro wrote: > > Adrian, > > > > Your comments are scattered over various functions, and so > > I would like to address them in separate replies. > > > > First, I'd like to discuss sdhci_[add|remove]_host(). > > > > On Fri, Aug 21, 2020 at 05:08:32PM +0300, Adrian Hunter wrote: > >> On 10/07/20 2:10 pm, Ben Chuang wrote: > >>> From: Ben Chuang > >>> > >>> In this commit, UHS-II related operations will be called via a function > >>> pointer array, sdhci_uhs2_ops, in order to make UHS-II support as > >>> a kernel module. > >>> This array will be initialized only if CONFIG_MMC_SDHCI_UHS2 is enabled > >>> and when the UHS-II module is loaded. Otherwise, all the functions > >>> stay void. > >>> > >>> Signed-off-by: Ben Chuang > >>> Signed-off-by: AKASHI Takahiro > >>> --- > > > > (snip) > > > >>> if (intmask & (SDHCI_INT_CARD_INSERT | SDHCI_INT_CARD_REMOVE)) { > >>> u32 present = sdhci_readl(host, SDHCI_PRESENT_STATE) & > >>> SDHCI_CARD_PRESENT; > >>> @@ -4717,6 +4812,14 @@ int sdhci_setup_host(struct sdhci_host *host) > >>> /* This may alter mmc->*_blk_* parameters */ > >>> sdhci_allocate_bounce_buffer(host); > >>> > >>> + if (IS_ENABLED(CONFIG_MMC_SDHCI_UHS2) && > >>> + host->version >= SDHCI_SPEC_400 && > >>> + sdhci_uhs2_ops.add_host) { > >>> + ret = sdhci_uhs2_ops.add_host(host, host->caps1); > >>> + if (ret) > >>> + goto unreg; > >>> + } > >>> + > >> > >> I think you should look at creating uhs2_add_host() instead > >> > >>> return 0; > >>> > >>> unreg: > >>> @@ -4738,6 +4841,8 @@ void sdhci_cleanup_host(struct sdhci_host *host) > >>> { > >>> struct mmc_host *mmc = host->mmc; > >>> > >>> + /* FIXME: Do we have to do some cleanup for UHS2 here? */ > >>> + > >>> if (!IS_ERR(mmc->supply.vqmmc)) > >>> regulator_disable(mmc->supply.vqmmc); > >>> > >>> @@ -4766,6 +4871,14 @@ int __sdhci_add_host(struct sdhci_host *host) > >>> mmc->cqe_ops = NULL; > >>> } > >>> > >>> + if ((mmc->caps & MMC_CAP_UHS2) && !host->v4_mode) { > >>> + /* host doesn't want to enable UHS2 support */ > >>> + mmc->caps &= ~MMC_CAP_UHS2; > >>> + mmc->flags &= ~MMC_UHS2_SUPPORT; > >>> + > >>> + /* FIXME: Do we have to do some cleanup here? */ > >>> + } > >>> + > >>> host->complete_wq = alloc_workqueue("sdhci", flags, 0); > >>> if (!host->complete_wq) > >>> return -ENOMEM; > >>> @@ -4812,6 +4925,9 @@ int __sdhci_add_host(struct sdhci_host *host) > >>> unled: > >>> sdhci_led_unregister(host); > >>> unirq: > >>> + if (IS_ENABLED(CONFIG_MMC_SDHCI_UHS2) && > >>> + sdhci_uhs2_ops.remove_host) > >>> + sdhci_uhs2_ops.remove_host(host, 0); > >>> sdhci_do_reset(host, SDHCI_RESET_ALL); > >>> sdhci_writel(host, 0, SDHCI_INT_ENABLE); > >>> sdhci_writel(host, 0, SDHCI_SIGNAL_ENABLE); > >>> @@ -4869,6 +4985,10 @@ void sdhci_remove_host(struct sdhci_host *host, int dead) > >>> > >>> sdhci_led_unregister(host); > >>> > >>> + if (IS_ENABLED(CONFIG_MMC_SDHCI_UHS2) && > >>> + sdhci_uhs2_ops.remove_host) > >>> + sdhci_uhs2_ops.remove_host(host, dead); > >>> + > >> > >> I think you should look at creating uhs2_remove_host() instead > > > > You suggest that we will have separate sdhci_uhs2_[add|remove]_host(), > > but I don't think it's always convenient. > > > > UHS-II capable host will be set to call sdhci_uhs2_add_host() explicitly, > > but we can't do that in case of pci and pltfm based drivers as they utilize > > common helper functions, sdhci_pci_probe() and sdhci_pltfm_register(), > > respectively. > > sdhci-pci has an add_host op > > sdhci_pltfm_init can be used instead of sdhci_pltfm_register > > > > Therefore, we inevitably have to call sdhci_uhs2_add_host() there. > > > > If so, why should we distinguish sdhci_uhs2_add_host from sdhci_uhs_add_host? > > I don't see any good reason. > > Moreover, as a result, there exists a mixed usage of sdhci_ interfaces > > and sdhci_uhs2_ interfaces in sdhci-pci-core.c and sdhci-pltfm.c. > > > > It sounds odd to me. > > It is already done that way for cqhci. Okay, if it is your policy, I will follow that. Then, I'm going to add - remove_host field to struct sdhci_pci_fixes - a controller specific helper function to each driver (only pci-gli for now) even though it looks quite generic. sdhci_gli_[add|remove]_host(struct sdhci_pci_slot *slot) { return sdhci_uhs2_[add|remove]_host(slot->host); } # Or do you want to create a file like sdhci-uhs2-pci.c for those functions? -Takahiro Akashi > > > > -Takahiro Akashi > > > > > >> > >>> if (!dead) > >>> sdhci_do_reset(host, SDHCI_RESET_ALL); > >>> > >>> > >> >