From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16A42C433E2 for ; Thu, 17 Sep 2020 08:34:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBBB82075E for ; Thu, 17 Sep 2020 08:34:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726420AbgIQIev (ORCPT ); Thu, 17 Sep 2020 04:34:51 -0400 Received: from verein.lst.de ([213.95.11.211]:55321 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726241AbgIQIej (ORCPT ); Thu, 17 Sep 2020 04:34:39 -0400 X-Greylist: delayed 464 seconds by postgrey-1.27 at vger.kernel.org; Thu, 17 Sep 2020 04:34:39 EDT Received: by verein.lst.de (Postfix, from userid 2407) id AA02367357; Thu, 17 Sep 2020 10:26:51 +0200 (CEST) Date: Thu, 17 Sep 2020 10:26:51 +0200 From: Christoph Hellwig To: Tong Zhang Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: fix use-after-free during booting Message-ID: <20200917082651.GA4595@lst.de> References: <20200916153605.5253-1-ztong0001@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200916153605.5253-1-ztong0001@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 16, 2020 at 11:36:05AM -0400, Tong Zhang wrote: > if a nvme controller is not responding during probing, a use-after-free > condition could happen This now leaks the queue for the regular teardown path.