From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2AC2C43461 for ; Thu, 17 Sep 2020 09:08:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 849C5206BE for ; Thu, 17 Sep 2020 09:08:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600333697; bh=71PMMX4XGwzhcDucaMkdKJC5uGHv8NBRfWU+pcx17cw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=TkjgalHAXYFyDorHUQ0P6tt0F8QBdDLWY0+cFmGNnyJUNoA55mjXeyFqThmXOFYId lbpiJLndPRYPPWhzuI6Gj+1m2GrFn6ndIf0Fq6/TRw0OKFpI5Tt+wPIIw0cWZSsiao LftD6nIz2MzBMlHqrhmLo+tYNo9+U5EZxlOXnLCE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726419AbgIQJIQ (ORCPT ); Thu, 17 Sep 2020 05:08:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:50630 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726211AbgIQJIP (ORCPT ); Thu, 17 Sep 2020 05:08:15 -0400 Received: from localhost (unknown [193.47.165.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D62CD20795; Thu, 17 Sep 2020 09:08:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600333694; bh=71PMMX4XGwzhcDucaMkdKJC5uGHv8NBRfWU+pcx17cw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ol5WmhOvI9rTFHgy8Vm01a+xGvI5mfTv9WBhdwoiPyKDHFLe79b8dV4Xg94ovNSEm s9uxKgsVD6kfIu4LtqFnl7Ad+hw1A3xZll7LH8LyHueKNgIMhX6DA30mCajLlPMYz4 astP5egLtpksNLrkl+aUOBY16OorzupdIFOwmpj4= Date: Thu, 17 Sep 2020 12:08:10 +0300 From: Leon Romanovsky To: Liu Shixin Cc: Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] RDMA/mlx5: fix type warning of sizeof in __mlx5_ib_alloc_counters() Message-ID: <20200917090810.GB869610@unreal> References: <20200917082926.GA869610@unreal> <20200917091008.2309158-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917091008.2309158-1-liushixin2@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 17, 2020 at 05:10:08PM +0800, Liu Shixin wrote: > sizeof() when applied to a pointer typed expression should give the > size of the pointed data, even if the data is a pointer. > > Signed-off-by: Liu Shixin > --- > drivers/infiniband/hw/mlx5/counters.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/infiniband/hw/mlx5/counters.c b/drivers/infiniband/hw/mlx5/counters.c > index 145f3cb40ccb..aeeb14ecb3ee 100644 > --- a/drivers/infiniband/hw/mlx5/counters.c > +++ b/drivers/infiniband/hw/mlx5/counters.c > @@ -456,12 +456,12 @@ static int __mlx5_ib_alloc_counters(struct mlx5_ib_dev *dev, > cnts->num_ext_ppcnt_counters = ARRAY_SIZE(ext_ppcnt_cnts); > num_counters += ARRAY_SIZE(ext_ppcnt_cnts); > } > - cnts->names = kcalloc(num_counters, sizeof(cnts->names), GFP_KERNEL); > + cnts->names = kcalloc(num_counters, sizeof(*cnts->names), GFP_KERNEL); This change is correct. > if (!cnts->names) > return -ENOMEM; > > cnts->offsets = kcalloc(num_counters, > - sizeof(cnts->offsets), GFP_KERNEL); > + sizeof(*cnts->offsets), GFP_KERNEL); This is not. > if (!cnts->offsets) > goto err_names; > > -- > 2.25.1 >