From: Greg KH <gregkh@linuxfoundation.org>
To: Hemant Kumar <hemantk@codeaurora.org>
Cc: manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, jhugo@codeaurora.org,
bbhatt@codeaurora.org
Subject: Re: [PATCH v6 4/4] bus: mhi: Add userspace client interface driver
Date: Thu, 17 Sep 2020 18:40:47 +0200 [thread overview]
Message-ID: <20200917164047.GB721081@kroah.com> (raw)
In-Reply-To: <1600286167-4432-5-git-send-email-hemantk@codeaurora.org>
On Wed, Sep 16, 2020 at 12:56:07PM -0700, Hemant Kumar wrote:
> +/**
> + * struct uci_dev - MHI uci device
> + * @minor: uci device node minor number
> + * @mhi_dev: associated mhi device object
> + * @chan: MHI channel name
> + * @lock: mutex lock
> + * @ul_chan: uplink uci channel object
> + * @dl_chan: downlink uci channel object
> + * @mtu: max tx buffer length
> + * @actual_mtu: maximum size of incoming buffer
> + * @open: open called for device node
> + * @enabled: uci device probed
> + * @ref_count: uci_dev reference count
> + */
> +struct uci_dev {
> + unsigned int minor;
> + struct mhi_device *mhi_dev;
> + const char *chan;
> +
> + /* protects uci_dev struct members */
> + struct mutex lock;
> +
> + struct uci_chan ul_chan;
> + struct uci_chan dl_chan;
> + size_t mtu;
> + size_t actual_mtu;
> + bool enabled;
> + struct kref ref_count;
> +};
I don't think you actually made the kernel documentation based on these
lines.
Or if you did, you ignored the warnings :(
Please test build your patches before sending them out...
thanks,
greg k-h
next prev parent reply other threads:[~2020-09-17 16:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 19:56 [PATCH v6 0/4] user space client interface driver Hemant Kumar
2020-09-16 19:56 ` [PATCH v6 1/4] bus: mhi: core: Add helper API to return number of free TREs Hemant Kumar
2020-09-27 3:12 ` Manivannan Sadhasivam
2020-09-16 19:56 ` [PATCH v6 2/4] bus: mhi: core: Move MHI_MAX_MTU to external header file Hemant Kumar
2020-09-27 3:14 ` Manivannan Sadhasivam
2020-09-16 19:56 ` [PATCH v6 3/4] docs: Add documentation for userspace client interface Hemant Kumar
2020-09-16 19:56 ` [PATCH v6 4/4] bus: mhi: Add userspace client interface driver Hemant Kumar
2020-09-16 21:52 ` Randy Dunlap
2020-09-17 16:40 ` Greg KH [this message]
2020-09-18 17:53 ` Hemant Kumar
2020-09-17 16:44 ` Greg KH
2020-09-18 18:14 ` Hemant Kumar
2020-09-19 6:03 ` Greg KH
2020-09-18 20:08 ` Jeffrey Hugo
2020-09-23 18:17 ` Hemant Kumar
2020-09-22 11:10 ` Loic Poulain
2020-10-01 3:30 ` Hemant Kumar
2020-09-17 8:47 ` [PATCH v6 0/4] user space " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917164047.GB721081@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).